Conversation
…egistry shipyard's pkg postinstall no longer writes the CMake user package registry and nothing reads it. build/msc.sh is resynced from shipyard's canonical template, which asks shipyard-cmake where find_package(MavericksShipyard) lands instead of reading ~/.cmake/packages. ci.yml's cmake-10_9-gate job is converted to shipyard-cmake/shipyard-ctest so conventions check 18 passes. That job is ALREADY failing on main for an unrelated reason -- d2e2707 ("Convert 1Password to a Porthole preset") deleted this repo's CMakeLists.txt and CMakePresets.json and left the job behind, so there is no `cross` preset for it to configure. This change does not repair that and does not make it worse; repairing it is out of scope here. BREAKING CHANGE: needs shipyard's shipyard-cmake on PATH (install@v1 provides it). Do not merge until shipyard has landed bc3082a. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GTxFde2TJMmp5p64DhvDSK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the 14-repo shipyard CMake flag day. Do not merge until shipyard has landed bc3082a.
After the cutover shipyard's pkg postinstall neither writes nor reads the CMake user package
registry; only
shipyard-cmake(from the shipyard pkg, onPATHviainstall@v1's default mode)may configure against shipyard.
build/msc.shresynced byte-for-byte from shipyard's canonicalscripts/templates/msc.sh(blob
43c2af0). It now probesshipyard-cmakeinstead of reading~/.cmake/packages/..github/workflows/ci.yml: thecmake-10_9-gatejob'scmake --preset cross,cmake --build build-crossandctest --preset crossconverted toshipyard-cmake/shipyard-ctest, and the comment claiming shipyard "self-registers in the userpackage registry" corrected.
No workflow step was added:
install@v1's default mode already putsshipyard-cmakeonPATH.Conventions gate (from shipyard
bc3082a): 5 failures ->ok, exit 0.Pre-existing, NOT fixed here
cmake-10_9-gateis already red onmain.d2e2707("Convert 1Password to a Porthole preset")deleted this repo's
CMakeLists.txtandCMakePresets.json; the job was left behind and there isno
crosspreset for it to configure. Converting its commands keeps the conventions gate green andchanges nothing about that failure. The job is orphaned and probably wants deleting, but that is a
separate decision.
🤖 Generated with Claude Code
https://claude.ai/code/session_01GTxFde2TJMmp5p64DhvDSK