Repository navigation
测试：TestPollTakesGuestArchFromListedConfig 不再因剩余磁盘空间偶发失败 - #151
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestPollTakesGuestArchFromListedConfig比较的实例 JSON 里带着data_space.host_free_bytes（实例所在硬盘当时的剩余空间）。两次读之间只要有别的程序写盘，这个数就变，测试就失败。11-13 在 #146 的 CI 和合并队列里（#147、#148）各挂过一次。这个测试比的是客体架构和 info / list 是否一致，跟剩余空间无关，所以比较前把这一项置零。
测试：后台一边反复写删 8 MB 文件一边各跑 40 次，改前失败，改后 40 次全过；
go vet ./internal/emu/通过。