Repository navigation
upgrade 项:新包有自动扩盘时核对旧盘已扩到 256 GB - #19
Merged
Merged
Conversation
管理器 0.8.0 起(ModAVD/ModAVDManager#132)没写模式的旧实例算自动扩盘,下次开机前就扩到 256 GB,再 set --data-gb 80 会被拒。新包的 info 里有 config.data_disk_mode 时改为核对模式是 auto、配置 >= 256 GB、/data >= 250 GB;没有时照旧改成 80 GB。 Refs ModAVD/ModAVD#153
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
为什么
ModAVD 0.40.0 的发版回归里,upgrade 项报失败,唯一的问题是「set --data-gb 80 失败:数据盘上限只能改大:实例 8 现在是 256 GB,不能改成 80 GB」。
管理器 0.8.0 起(ModAVD/ModAVDManager#132)数据盘分「自动扩盘 / 指定大小」两种,没写模式的旧实例算自动扩盘,下次开机前就扩到 256 GB。这一项升级前后都用新包的 modavd 开机,所以旧版建的 64 GB 盘在升级前那次开机就扩到了 256 GB,再改成 80 GB 当然被拒。产品行为是对的,是这一项的核对过时了。
Refs ModAVD/ModAVD#153
改了什么
items/upgrade.ps1:升级后先看新包 modavd 的info --json有没有config.data_disk_mode:auto、配置 ≥ 256 GB、客体/data≥ 250 GB,不再set --data-gb 80;set --data-gb 80再开机看扩满。suites/release.psd1里这一项的判据跟着改。测试
在
E:\testbed\flow-b上用 0.40.0 的候选包(上一版是 0.39.1 的组包目录)跑 upgrade 项:info --json的路径写错(写成data.instance.config,info 的是data.config),走了老路,照样报 80 GB 被拒;已改。auto、配置 256 GB、/data255.5 GB,但当时还要求「升级后第一次开机的输出里有『数据盘已扩到』」而报失败:扩盘在升级前那次开机就做完了。去掉了这条要求。没测:拿还没有两种模式的旧新包(比如 0.39.1 → 0.39.1)走
set --data-gb 80那条老路;这条路的代码没动,只是挪进了 else。