Repository navigation
fetch 项:「补全组件.bat」是 0.38.2 起不随包,不是 0.39 - #18
Merged
Merged
Conversation
ModAVD/ModAVD#119 进的是 v0.38.2,v0.38.1 的包里还有批处理。结果说明、 注释里的「0.39 起」改成「0.38.2 起」,测试的假组包目录改名 pkg-0.38.2。 跑法和断言不变。 Refs ModAVD/ModAVD#139
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
为什么
fetch 项的结果说明和几处注释说「补全组件.bat」是 0.39 起不随包,实际 0.38.2 就去掉了:ModAVD/ModAVD#119 进的是 v0.38.2,v0.38.1 的包里还有批处理(ModAVD/ModAVD#139)。结果说明会进回归报告,测 0.38.2 的包时对不上。
改了什么
items/fetch-lib.ps1、items/fetch.ps1、tests/fetch-item.ps1里的「0.39 起」改成「0.38.2 起」。pkg-0.39改名pkg-0.38.2。测试
pwsh -NoProfile -File tests/fetch-item.ps1:152 项通过。Refs ModAVD/ModAVD#139