Open
Conversation
While multiple clients Add(MF.SimVars.Add.xxxxRPNcodexxx) the exact same SimVars to WASM,
From MSFS2020 perspective, it is unnecessary to execute the same RPNcode several times in each frame. This is an enhancement change to reduce FPS impact
WASM will smartly execute duplicated SimVars only once in each frame.
introduce new data structure:
//RPN code execution for reading values in every frame
struct ReadRPNCode {
std::string Code;
int RetType; //RetType: 0:float 1:integer 2:string
std::vector<SimVar> SimVars;
std::vector<StringSimVar> StringSimVars;
};
--
This patch is stable because we have 1000+ customers who have been using these changes over a year
MF.LVars.List.Start I_FCU_EFIS1_ARPT;I_ECAM_COND;... MF.LVars.List.Cont I_ASP2_INT_REC;I_ASP4_VOICE;... MF.LVars.List.Cont I_ASP2_PA_REC;I_ASP4_CAB_SEND;... MF.LVars.List.End
Collaborator
|
Please describe what this change is addressing and please rebase as soon as we have the other PR merged because this one includes the changes from the other PR. THANK YOU SO MUCH FOR YOU EFFORTS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MF.LVars.List.Start
I_FCU_EFIS1_ARPT;I_ECAM_COND;...
MF.LVars.List.Cont
I_ASP2_INT_REC;I_ASP4_VOICE;...
MF.LVars.List.Cont
I_ASP2_PA_REC;I_ASP4_CAB_SEND;...
MF.LVars.List.End