-
Notifications
You must be signed in to change notification settings - Fork 0
feat: New getR128Gain function to get track replay gain value
#16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f55c2da
chore: Class to help parse the track gain
cyanChill 1fe8c4d
chore: Export function to extract replay gain value
cyanChill beb1ded
docs: Mention new `getR128Gain` function in README
cyanChill bc4eb94
fix: Also break out of outer loop
cyanChill 8a66d92
chore: Also support `R128_TRACK_GAIN` replay gain tag + FLAC support
cyanChill 32b352b
fix: `R128_TRACK_GAIN` needs to be divided by `256f`
cyanChill b3fb126
fix: Use `firstOrNull` for our lyrics as well
cyanChill File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
android/src/main/java/com/cyanchill/missingcore/metadataretriever/utils/ReplayGainParser.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| package com.cyanchill.missingcore.metadataretriever.utils | ||
|
|
||
| import androidx.annotation.OptIn | ||
| import androidx.media3.common.Metadata | ||
| import androidx.media3.common.util.UnstableApi | ||
| import androidx.media3.extractor.metadata.id3.TextInformationFrame | ||
| import androidx.media3.extractor.metadata.vorbis.VorbisComment | ||
| import androidx.media3.extractor.mp3.Mp3InfoReplayGain | ||
|
|
||
| @OptIn(UnstableApi::class) | ||
| class ReplayGainParser(entry: Metadata.Entry) { | ||
| var gain: Float? = null | ||
|
|
||
| init { | ||
| // Extract track gain based on the class. | ||
| gain = when (entry) { | ||
| is TextInformationFrame -> handleTextInformationFrame(entry) | ||
| is Mp3InfoReplayGain -> handleMp3InfoReplayGain(entry) | ||
| is VorbisComment -> handleVorbisComment(entry) | ||
| else -> null | ||
| } | ||
| } | ||
|
|
||
| private fun handleTextInformationFrame(frame: TextInformationFrame): Float? = | ||
| when (frame.description?.uppercase()) { | ||
| "REPLAYGAIN_TRACK_GAIN" -> frame.values.firstOrNull()?.parseReplayGainAdjustment() | ||
| //? R128 gain needs to be divided by `256f`. | ||
| "R128_TRACK_GAIN" -> frame.values.firstOrNull()?.parseReplayGainAdjustment()?.div(256f) | ||
| else -> null | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| } | ||
|
|
||
| /** For when we see `ReplayGain Xing/Info`. */ | ||
| private fun handleMp3InfoReplayGain(frame: Mp3InfoReplayGain): Float? { | ||
| return frame.field1?.gain | ||
| } | ||
|
|
||
| private fun handleVorbisComment(comment: VorbisComment): Float? = | ||
| when (comment.key.uppercase()) { | ||
| "REPLAYGAIN_TRACK_GAIN" -> comment.value.parseReplayGainAdjustment() | ||
| //? R128 gain needs to be divided by `256f`. | ||
| "R128_TRACK_GAIN" -> comment.value.parseReplayGainAdjustment()?.div(256f) | ||
| else -> null | ||
| } | ||
|
|
||
| /** Some replay gain tags include "dB" in the string. */ | ||
| private fun String.parseReplayGainAdjustment() = | ||
| replace(Regex("[^\\d.-]"), "").toFloatOrNull() | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.