Fix/explicit rpid config - #585
Open
Davoski1 wants to merge 2 commits into
Open
Conversation
added 2 commits
July 29, 2026 17:32
…e .well-known files for passkeys
…C_RP_ID / NEXT_PUBLIC_ORIGIN)
|
@rhoggs-bot-test-account is attempting to deploy a commit to the miracle656's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supply the Relying Party ID (rpId) and origin explicitly in the wallet configuration so native builds do not fall back to
localhost.Changes
frontend/wallet/lib/network.tsrpIdandoriginfields towalletConfig, read fromNEXT_PUBLIC_RP_IDandNEXT_PUBLIC_ORIGIN.examples/nextjs/src/lib/network.tsrpId/originadditions for the example app.Why
Native apps (Expo / React Native) lack
window.location.hostname, causing the SDK to default tolocalhost. That breaks passkey binding on real devices because the relying-party id must match the production domain. ReadingrpIdandoriginfrom environment variables allows CI and device builds to set the correct production values without changing source.Notes for maintainers / operators
NEXT_PUBLIC_RP_ID(e.g.veil.app) andNEXT_PUBLIC_ORIGIN(e.g.https://veil.app) in your environment/CI before building production artifacts.Testing / Verification
NEXT_PUBLIC_RP_ID=veil.appandNEXT_PUBLIC_ORIGIN=https://veil.appset and verifywalletConfigpassed touseInvisibleWallet()contains those values.localhost).Closes #442