Add Svelte adapter for invisible-wallet-sdk - #555
Conversation
|
Someone is attempting to deploy a commit to the miracle656's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 33210559 | Triggered | Generic Password | 19ba67f | examples/sveltekit/src/lib/network.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
Good day maintainer |
|
Reviewed and holding this open on one blocker, which I can't clear myself. Blocker: GitGuardian
I searched for it and could not find a committed credential:
My guess is a generic high-entropy or "secret assignment" heuristic firing on For context: your earlier #191 targeted the same issue and reported the identical GitGuardian failure, so whatever it is, it predates this branch's specific contents. I closed #191 in favour of this one — it was The code itselfReads well. One thing worth changing regardless of the GitGuardian outcome: the example persists the fee-payer secret in Leaving this open rather than closing — the work is sound and it should merge once the security check is cleared. |
|
Okay I will fix it soon |
localStorage is readable by any script on the origin. Use sessionStorage instead so the key clears when the tab closes, and note in-code that a production wallet should keep this in memory or behind a non-extractable key. Also drops "secret" from the storage key name.
|
Hello maintainer |
Adds a Svelte adapter and SvelteKit example.
@veil/invisible-wallet-svelte(sdk/svelte): a writable store wrapping the framework-agnosticinvisible-wallet-sdk/vanillacore, exposingregister/deploy/login/sign/sendhelpers and a reactive{ status, walletAddress, error }store. Add a SvelteKit example (examples/sveltekit) with register, dashboard, and send routes, and document the adapter in the top-level README.Closes #174