done

[SpacePanda7077]

Summary

Related issue

Type of change

• Bug fix
• New feature
• Refactor
• Docs
• Tests
• CI / tooling

Component

• Wallet frontend
• SDK
• Contracts
• Agent

Checklist

• I have read CONTRIBUTING.md
• cargo test passes (contracts)
• npm run typecheck passes (wallet / sdk / agent)
• npm run build passes (wallet / agent)
• I added or updated tests where relevant
• I updated docs / README where relevant

Screenshots / test output

[vercel]

@SpacePanda7077 is attempting to deploy a commit to the miracle656's projects Team on Vercel.

A member of the Team first needs to authorize it.

[drips-wave]

@SpacePanda7077 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

[Miracle656]

Thanks for the port — and I owe you an explanation rather than just a rejection, because the outcome here isn't your fault.

The overlap

#436 ("8. Port lib/network.ts") is assigned to you, and this PR does what it asks. But #489 ("61. Network switch") is assigned to @Y33t-dev, and delivering a runtime network switch necessarily includes porting lib/network.ts — so #526 also creates frontend/mobile/lib/network.ts, at 205 lines with 273 lines of tests, a useNetwork hook, and a settings screen.

Two issues, two people, overlapping surface. That's my mistake in how I split the backlog, not yours — you took an assigned issue and did the work in it.

Since #526's version is a strict superset (it contains the port plus the switching layer, and its tests pass), I'm keeping that one and closing #436 as covered by #489. I'll unassign you from #436 so it isn't sitting on your queue.

Please pick another issue and I'll assign it to you — comment on whichever one you'd like. Given you've already been through the network code, something in the same area would be a quick second win.

Feedback for next time

Two habits worth adopting, and they'd have surfaced this collision before you wrote the code:

Fill in the PR template. Right now the title is done and the body is the unedited template — every checkbox blank, and the related-issue line still commented out:

## Related issue
<!-- Closes #436  -->

Because it's inside an HTML comment, GitHub doesn't parse it, so this PR isn't linked to #436 at all. That link is what surfaces a collision like this one: if it had been live, #436 would have shown both PRs side by side and I'd have caught the overlap before you invested the effort.

Uncomment it and it works:

Closes #436

A descriptive title. done tells a reviewer nothing in a list of 40 open PRs. Something like feat(mobile): port lib/network.ts (#436) would do it.

Neither of these is about ceremony — they're the mechanism by which overlapping work gets spotted early. Your tests/network.test.ts shows you write tests unprompted, which is more than most, so this is worth getting right.

Closing this one. Comment on an issue you'd like and I'll assign it.