Merged
Conversation
# Conflicts: # environments/py-3.12-linux-64-dev.conda.lock.yml # environments/py-3.12-linux-64.conda.lock.yml # environments/py-3.12-win-64-dev.conda.lock.yml # environments/py-3.12-win-64.conda.lock.yml # environments/py-3.13-linux-64-dev.conda.lock.yml # environments/py-3.13-linux-64.conda.lock.yml # environments/py-3.13-win-64-dev.conda.lock.yml # environments/py-3.13-win-64.conda.lock.yml # environments/py-3.14-linux-64-dev.conda.lock.yml # environments/py-3.14-linux-64.conda.lock.yml # environments/py-3.14-win-64-dev.conda.lock.yml # environments/py-3.14-win-64.conda.lock.yml # py-3.12.conda-lock.yml # py-3.13.conda-lock.yml # py-3.14.conda-lock.yml
MatthieuCMira
requested changes
Mar 3, 2026
Contributor
MatthieuCMira
left a comment
MatthieuCMira
left a comment
There was a problem hiding this comment.
I might not be the best to review english.
Maybe run a colpilote review?
Some links are 404 errors.
And Some figures are old analyst. As you are changing the file, maybe you could retake thge screenshots?
Moreover, there is an error in the github tests.
As you changed the toml file, would be nice to fix it
Co-authored-by: MatthieuCMira <109624972+MatthieuCMira@users.noreply.github.com>
# Conflicts: # environments/py-3.12-linux-64-dev.conda.lock.yml # environments/py-3.12-linux-64.conda.lock.yml # environments/py-3.12-win-64-dev.conda.lock.yml # environments/py-3.12-win-64.conda.lock.yml # environments/py-3.13-linux-64-dev.conda.lock.yml # environments/py-3.13-linux-64.conda.lock.yml # environments/py-3.13-win-64-dev.conda.lock.yml # environments/py-3.13-win-64.conda.lock.yml # environments/py-3.14-linux-64-dev.conda.lock.yml # environments/py-3.14-linux-64.conda.lock.yml # environments/py-3.14-win-64-dev.conda.lock.yml # environments/py-3.14-win-64.conda.lock.yml # py-3.12.conda-lock.yml # py-3.13.conda-lock.yml # py-3.14.conda-lock.yml
benk-mira
requested changes
Mar 4, 2026
Contributor
benk-mira
left a comment
benk-mira
left a comment
There was a problem hiding this comment.
Looking good overall. Couple suggestions/questions.
|
|
||
| 1. **Parameter retrieval**: The application reads the conductor geometry (strike length, dip length, width, dip angle, conductivity) from the ui.json metadata stored in the simulation file. | ||
|
|
||
| 2. **Spatial positioning**: The application positions the plate at the centroid of the matched survey segment, adjusted vertically by the overburden thickness. |
Contributor
There was a problem hiding this comment.
Is this right? Why not position it based on the depth of the matched plate?
Collaborator
Author
There was a problem hiding this comment.
Because that's the reference of a Maxwell plate (center top of the plate). Our reference center for Plate is at the center of mass (xyz center), which requires some trig to compensate for the dip angle.
docs/plate-simulation/sweep.rst
Outdated
|
|
||
| .. figure:: /plate-simulation/images/sweep_landing.png | ||
| :align: center | ||
| :width: 80% |
Contributor
There was a problem hiding this comment.
Suggested change
| :width: 80% | |
| :width: 50% |
docs/plate-simulation/sweep.rst
Outdated
|
|
||
| .. figure:: /plate-simulation/images/summary.png | ||
| :align: center | ||
| :width: 60% |
Contributor
There was a problem hiding this comment.
Suggested change
| :width: 60% | |
| :width: 80% |
Co-authored-by: benk-mira <81254271+benk-mira@users.noreply.github.com>
benk-mira
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.