ci: run the pipeline on pull requests - #8
Open
PAMF2 wants to merge 1 commit into
Open
Conversation
Fork PRs never triggered CI (push-only), so the seven open fix PRs sit unvalidated while main is red on the rocksdb NIF build. PRs now run the same pipeline; first candidate to benefit is #6, which claims to fix exactly the rocksdb/libsnappy build that breaks main.
Author
|
Note on this PR's own red check: the new trigger did its job - it ran the pipeline and surfaced main's existing rocksdb NIF build failure (red on main since 2026-08-17, run 21:40). This branch changes only ci.yml; the red is inherited base state, which #6 (libsnappy-dev + git context) claims to fix. Merging this + re-pushing #6 gives the verdict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main has been red since 2026-08-17 on the rocksdb NIF build, and the likely fix (#6, libsnappy-dev + git context) has sat unvalidated since 2026-08-14 because
ci.ymlonly triggers on push - fork PRs run nothing. One-file change:pull_requesttrigger so every PR runs the same pipeline. Merging this first lets #1-#7 validate themselves.