Added Support for Webhook Components#63
Closed
jasonlessenich wants to merge 22 commits intoMinnDevelopment:masterfrom
Closed
Added Support for Webhook Components#63jasonlessenich wants to merge 22 commits intoMinnDevelopment:masterfrom
jasonlessenich wants to merge 22 commits intoMinnDevelopment:masterfrom
Conversation
MinnDevelopment
requested changes
Aug 7, 2022
Owner
MinnDevelopment
left a comment
MinnDevelopment
left a comment
There was a problem hiding this comment.
Looking good already, but will need some work.
In general the documentation should always include a description, even for getters. This is useful because it shows directly next to the method in the javadoc html.
You should check your file encoding to make sure my name actually shows up correctly, it is Spieß which includes a non-ascii letter.
You generally only add support for sending components, not getting them from existing messages via ReadonlyMessage. This is not a huge deal to me though, and I can just add that later myself. But I wanted to point that out regardless.
Comment on lines
+196
to
+199
| * @throws java.lang.NullPointerException | ||
| * If provided with null | ||
| * @throws java.lang.IllegalStateException | ||
| * If more than {@value LayoutComponent#MAX_COMPONENTS} are added |
Owner
There was a problem hiding this comment.
Throws docs should be after param and before return:
/*
* description text ...
*
* @param ...
* description
*
* @throws ...
* description
*
* @return ...
*/
| .collect(Collectors.toList())); | ||
| mentions.getRoles().stream() | ||
| .map(Role::getId) | ||
| .collect(Collectors.toList())); |
Owner
There was a problem hiding this comment.
Why was all this indentation changed?
src/main/java/club/minnced/discord/webhook/send/component/ActionComponent.java
Outdated
Show resolved
Hide resolved
| void withDisabled(boolean disabled); | ||
|
|
||
| /** | ||
| * @return true if the button is disabled |
|
|
||
| /** | ||
| * Changes the disabled status of button | ||
| * @param disabled |
Owner
There was a problem hiding this comment.
Suggested change
| * @param disabled | |
| * | |
| * @param disabled |
| */ | ||
|
|
||
| public interface Component extends JSONString { | ||
|
|
|
|
||
| public class Button implements ActionComponent, SingleEmojiContainer<Button> { | ||
|
|
||
| public static final int MAX_BUTTONS = 5; |
Owner
There was a problem hiding this comment.
Move this into LayoutComponent
src/main/java/club/minnced/discord/webhook/send/component/ActionRow.java
Outdated
Show resolved
Hide resolved
| * @return true if the button is disabled | ||
| */ | ||
| boolean isDisabled(); | ||
|
|
| * @see LayoutComponent#addComponent(ActionComponent) | ||
| */ | ||
| public interface ActionComponent extends Component { | ||
|
|
…onRow.java Co-authored-by: Florian Spieß <business@minn.dev>
…onRow.java Co-authored-by: Florian Spieß <business@minn.dev>
…onComponent.java Co-authored-by: Florian Spieß <business@minn.dev>
…on.java Co-authored-by: Florian Spieß <business@minn.dev>
…onent.java Co-authored-by: Florian Spieß <business@minn.dev>
…onent.java Co-authored-by: Florian Spieß <business@minn.dev>
…onent.java Co-authored-by: Florian Spieß <business@minn.dev>
…utComponent.java Co-authored-by: Florian Spieß <business@minn.dev>
…utComponent.java Co-authored-by: Florian Spieß <business@minn.dev>
…ialEmoji.java Co-authored-by: Florian Spieß <business@minn.dev>
…ialEmoji.java Co-authored-by: Florian Spieß <business@minn.dev>
…ialEmoji.java Co-authored-by: Florian Spieß <business@minn.dev>
…ctMenu.java Co-authored-by: Florian Spieß <business@minn.dev>
…ctMenu.java Co-authored-by: Florian Spieß <business@minn.dev>
…ctMenu.java Co-authored-by: Florian Spieß <business@minn.dev>
…utComponent.java Co-authored-by: Florian Spieß <business@minn.dev>
…onRow.java Co-authored-by: Florian Spieß <business@minn.dev>
Owner
|
Continuing this in #73 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to add Webhook Components. (Closes #46)
I've mainly just copied all changes from RohanGoyalDev's PR (#56) and fixed all the remaining issues.