Skip to content

fix: update Codex catalog client version to 0.162.0 - #477

Merged
yujiachen-y merged 1 commit into
mainfrom
fix/codex-catalog-client-version
Oct 11, 2026
Merged

yujiachen-y merged 1 commit into
mainfrom
fix/codex-catalog-client-version

Conversation

@yujiachen-y

@yujiachen-y yujiachen-y commented Oct 10, 2026 •

Copy link
Copy Markdown
Collaborator

Change

Codex OAuth model discovery sends client_version=0.153.0, which the report in #473 shows receiving an incomplete catalog. Update it to 0.162.0, the version used by the reporter's installed Codex CLI and included in their successful same-account comparison.

The existing OAuth integration test now checks the complete discovery URL, including the compatibility version, and the model-system documentation matches it. This is a three-line change across three existing files. OAuth login/error handling (#472) and automatic version discovery are outside this PR.

Fixes #473.

Validation

  • PASS: focused Codex OAuth and TUI login tests, 38/38.
  • Regression check: the tightened URL assertion failed against 0.153.0 and passed after the bump.
  • PASS: MCODE_VERIFY_REPORT_DIR=/tmp/mcode-issue473-20261011 pnpm verify on committed d86e2c1fd6b700c7899136b55509c84df837debe with a clean tracked working tree (macOS arm64, Node v26.1.0): all 15 applicable gates passed. Windows checks were skipped on macOS, and release-package checks were skipped because no npm release archive was supplied.
  • PASS: git diff --check; the built runtime chunk contains 0.162.0 and no 0.153.0.
  • Performance: basic automatic suite; no performance-sensitive paths or dependencies changed.
  • NOT RUN: live ChatGPT OAuth, account-specific model availability, or inference with newly discovered models. The catalog comparison is evidence supplied by the issue reporter, not an independent live-service test.

Publication and contribution checks

  • I have permission to contribute these changes under the existing licenses applicable to the changed files/packages; no imported material or changed notices.
  • No credentials, account data, real user content, internal source history or private review material is included.
  • No source files were added or removed, and the test remains in its existing declared suite; inventory regeneration is not needed.
  • The existing model-system documentation is updated. Offline results are not described as live-service acceptance.

Maintainer handoff

Publication scope or license changes: none.

Shared-source port: pending. This PR updates the published CLI/runtime source; it does not itself publish a Desktop release. The compatibility version remains a manual pin and may need future maintenance.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@yujiachen-y yujiachen-y added bug Something isn't working cli Standalone mcode: TUI, headless, ACP and source builds/tooling labels Oct 10, 2026

@hetaoBackend hetaoBackend left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minimal and correct: 0.162.0 matches the comparison data in #473 (0.153.0 returns 4 models, 0.160.0 and above return 7) and the version the reporter's Codex CLI uses. The old value only appears in codex-model-discovery.ts and the model-system README, and both are updated. The tightened URL assertion in the test is a good change.

Two non-blocking suggestions:

  1. This is still a hand-maintained pin and will go stale again. A short comment on the constant saying which Codex CLI version it came from and how to update it would help the next person.
  2. The test hard-codes the full URL, so every bump needs a matching test edit. That is fine if you want bumps to be deliberate; importing the constant in the test would avoid the double edit.

Not verified: live ChatGPT OAuth and account-specific model availability, as noted in the PR.

@yujiachen-y
yujiachen-y merged commit cee0791 into main Oct 11, 2026
15 checks passed
cursor Bot pushed a commit to kinetick-labs/kinetick-code that referenced this pull request Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cli Standalone mcode: TUI, headless, ACP and source builds/tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Codex 模型目录缺失 GPT-6 系列(client_version 硬编码为 0.153.0)

2 participants