Repository navigation
Reject input whose selected Credential was deleted - #863
Merged
Merged
Conversation
SaladDay
force-pushed
the
fix/input-deleted-credential
branch
from
October 25, 2026 02:48
268ff48 to
ee239ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Session whose frozen MCP Credential binding names a Credential that was deleted (or whose Vault was deleted) now rejects new message input with the same 400 selection error that Session creation returns for an absent Credential, instead of admitting a Turn that fails at dispatch.
vaults.Service.CheckMCPCredentialsreads metadata only, reusingFindMCPCredentials.Worker.SubmitInputsruns the check for message batches on a Session with no active Turn, before and outside the admission transaction.sessions.Service.InputAdmitted).vaults.mdand thesessions-events.mdinput error table describe the behavior (EN + ZH).Checks: focused
go testfor vaults, execution, sessions, api and the new integration testmcp_credential_input_test.go.Need help on this PR? Tag
@codesmith-botwith what you need.