Repository navigation
Fix E2B hosted startup on fresh installations - #855
Merged
Merged
Conversation
A real E2B run on a fresh Compose installation found two adapter faults that together kept every E2B Session from starting: - Nothing created the adapter's private /state/e2b since the Compose installer replaced the Python one, so selecting E2B failed with 503 execution_unavailable. The adapter now creates the directory (0700) when Core loads the Provider. - The E2B API omits the domain of a sandbox on the configured one. SDK Sandbox objects fill it in, SandboxInfo leaves None, so every check of GetInfo (create qualification, inspect, renew, resume) rejected an owned sandbox as foreign. An omitted domain now counts as the configured one; a reported foreign domain is still refused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A real E2B run (fresh Compose install of f5ecb85 behind a public HTTPS origin, template built from its Runtime image) found two E2B adapter faults that together kept every E2B Session from starting.
/state/e2b, andConfig.Validaterequires it, soPOST /core/v1/sandbox/deploymentwith E2B returned 503execution_unavailable. The adapter now creates it (0700) when Core loads the Provider.Sandboxobjects fill in the configured domain,SandboxInfoleavesNone. EveryGetInfocheck (create qualification, inspect, renew, resume) therefore rejected an owned sandbox as foreign (configuration_rejected, "initialization did not complete"). An omitted domain now counts as the configured one; a reported foreign domain is still refused.Tests:
TestBuildDirectCreatesItsPrivateStateDirectory;test_info_without_a_domain_is_on_the_configured_one(fails without the fix).make check-e2b-provider(196 tests),go test ./internal/sandbox/e2b/, module-widego vet.Live check: with the fixed helper swapped into that installation, a codex hosted Turn on E2B completes.
Need help on this PR? Tag
@codesmith-botwith what you need.