Repository navigation
Delete unused Web and client code - #829
Merged
Merged
Conversation
- Web: Button, AnimatedShinyText, BlurFade, EntityChip, unused Select exports, shiny-text keyframes - Web: dashboard-model, the client-side runtime sampling path, held-usage and their tests - Web: unused helpers (useSandboxProvider, formatCompactNumber, isAbortError x2, pendingPlaintext, readSkillsPage, uploadPrecheck, readFilesPage, TraceView formatters) and unused imports, locals and e2e locals - Web: @tanstack/react-table dependency, unused i18n keys and dead CSS selectors - agents-client: unused and test-only type aliases, sandboxNodeDiagnostics alias, unused index re-exports - Root package.json typecheck and test scripts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure deletion of unused Web and agents-client code (see commit message). Parsar example and draft PR #700 branch checked: none of the removed exports are used there.
Checks passed: agents-client typecheck + vitest (741), web typecheck + vitest (22 files) + build, parsar-example typecheck + test (346) + build. Not run: Playwright (web acceptance, example test:e2e), make check.
Kept: normalizeSandboxNodeDiagnostic and projectCoreMetrics (export * modules, internal use, tests import them), OpenAIAgentsClientOptions/CoreErrorDetail(s)/CoreClientOptions (client construction/error API).
Need help on this PR? Tag
@codesmith-botwith what you need.