Repository navigation
Delete unused daemon and shared Go code - #828
Merged
Merged
Conversation
SaladDay
force-pushed
the
delete-unused-daemon-and-shared-go-code
branch
from
October 23, 2026 18:25
b52f310 to
790e042
Compare
- claudesdk prepare wrapper, localworkspace.ToolEnvironmentFile - agent.WorkspaceWriter interface, its stub methods, assertions and docs - Codex UserInputLocalImage, UserInput.Path, ThreadStartedNotification, providerConfig Name/HTTPHeaders/QueryParams and their TOML rendering - Write-only fields: codex ModelReasoningEffort, rpc exitCode, subagentEffect source/turn/call, MCPBinding ConnectionOrigin/CredentialAuthority, EnvironmentMCP.WorkspaceRoot, PreparedConfiguration.Provider, transport DialOptions.HTTPHeader - proto DonePayload.Transcript, Usage InputTokens/OutputTokens/CostUSD - Unread Codex decode fields: Thread preview/updatedAt/cliVersion, TurnError additionalDetails, item startedAtMs/completedAtMs - claude-sdk-adapter textInput export (moved into its test) - Correct the OAC_RUNTIME_HOME comment in paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes daemon and shared Go code that nothing in production uses: unreachable functions, the WorkspaceWriter interface and its stubs, Codex protocol leftovers, write-only fields, unread Codex decode fields, proto Usage/DonePayload fields Core never reads, and the unused claude-sdk-adapter textInput export. Docs (harness-onboarding, zh mirror with new source_hash) updated.
Checks: go build/vet ./...; go test for apps/daemon, internal, Core execution and runtimegateway; make check-harness-catalog; make check-claude-sdk; website translations test; deadcode shows nothing newly unreachable.
Need help on this PR? Tag
@codesmith-botwith what you need.