Repository navigation
Run Codex on Windows with the default verbosity - #518
Merged
Merged
Conversation
Protocol medium is the default text amount: a model with verbosity support applies the override, and Codex ignores it for any other model. Codex therefore needs no catalog probe for medium, so it is available on Windows, where the probe cannot run, with TextVerbosity unsupported. Core requires TextVerbosity only for an explicit non-medium verbosity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
native / platform (windows-amd64)failure on #515 and #516. R1 made Codex unavailable on Windows, because the model-catalog probe needs Unix process groups, so the Windows onboarding smoke (which installs Codex) never saw its Harness connect.The probe is needed only for
lowandhigh. Protocolmediumis the default text amount: a model with verbosity support applies themodel_verbosityoverride, and Codex ignores it for any other model. So:mediumon every platform, and Codex is available again on Windows, declaringTextVerbosityunsupported;text_verbosityonly for an explicit non-mediumverbosity, instead of whenever the profile supports it;Checks: Codex adapter tests, Core
execution, integrationTestExecutionRejectsRuntimeMissingCapabilityBeforeClaim(now with an explicithighverbosity), darwin and windows daemon builds,make check-names check-docs check-ci.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.