Repository navigation
Delete the process deployment path - #517
Merged
Merged
Conversation
SaladDay
force-pushed
the
refactor/process-deployment
branch
from
October 7, 2026 18:26
096435e to
4f6616f
Compare
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Web setup is the only way a sandbox deployment is configured in production: Core builds its runtime provider only through
NewDeferredRuntimeProvider, which always loads the Web-written setup. The process-configured deployment path, its "Local" node and the direct-capacity accounting were reachable only from tests. This change deletes them and ports the tests to the production seam. It is T3a in the architecture audit; the user decided (D1) to do it now, on main.Deleted:
ProcessDeployment, the selection arms ofConfigureProcess(nowRequireUnclaimed),configureManagerand its local node;SetProcessDeployment/SetRuntimeManagerDeploymentand their queries;Local*fields,ErrLocalNodeConfiguredand theruntime_local_node_configurederror;RuntimeProvidernow requiresModeandProviderKind;MaxActive/MaxRetainedin the suspension policy,computeCapacity*, theProviderKind == ""/NodeID == ""branches, andCountComputeReservations/CountRetainedAllocations.Derived columns dropped (migration 000093):
web_managed(always true once an installation is recorded);local_node_id;admission_paused(always equal toreset_clear IS NOT NULL).Every CHECK constraint that mentioned them is rewritten in terms of
installation_id IS NOT NULL. The upgrade refuses any row the derivations don't hold for, and any live node with an empty Core address. Down restores the columns and constraints.Dead branches deleted after the derivation: the "paused for provider maintenance" admission branch, the paused arms of placement, three enrollment checks that a reset check already covers, and the unreachable resource guard in the nil arm.
NewDeferredRuntimeProvidertakes a requiredprepare.Web: the "file-managed local node" logic in
NodeList.tsxand two unused "Local nodes" strings are deleted.Tests: they use the production seam through shared helpers (
webDeployment,webRuntimes,startWebWorker,enrollNode). Each keeps its acceptance meaning; the maintenance cases became reset cases.Behaviour
Not in this change
The
kept_at/ empty-mode rule in seven allocation queries stays. An unclaimed deployment still admits hosted Sessions, so deleting the rule properly needs its own change: refuse hosted admission while unclaimed, then delete the Keep path and thekept_atcolumn.Review
A fresh-context blind review found no must-fix. Its verdict was "merge after fixes". Both should-fixes (the dead
Registry.IsNode, and a stale sentence inconsole-api-usage.mden/zh) and its nits (a stale test name, a redundant test case, the unused locale strings, a migration error message that names the cause) are fixed in this commit.Checks
go build ./..., module vet,sqlc diff(clean) andmake check-openapi.tests/integration: 157 passed. The official-client tests ran with the pinned SDK.check-names.py.Net: non-test −232, sqlc −68, tests −477.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.