Repository navigation
Reach the live cold continuations the way Core does - #511
Merged
Merged
Conversation
The MCP bearer test released the Executor with execution_release after the Run had started, which never retires it, so the cold step failed. It now drops the connection and binds again, so the daemon's Router closes the Executor on shutdown and the next Run starts a fresh native process. The registered Claude SDK test failed on the non-terminal preparing and starting statuses, and resumed with require_existing_native_session, which Core sends only to recover a Turn whose native identity is unknown. It now fails only on terminal statuses and resumes by native identity. Both pass live against MiniMax.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two live acceptance tests were stale, and both now pass live against MiniMax:
TestLiveMCPBearerGatewayColdContinuationsentexecution_releaseafter the Run had started, which never retires the Executor (runtime-protocol.md, execution step 5), so the cold step failed. It now drops the connection and binds again: the daemon's Router closes the Executor on shutdown, and the next Run starts a fresh native process with a fresh bearer reference. A Router never rebinds a released Session, so release and rebind on one connection is not an option.TestLiveRegisteredClaudeSDKfailed on the non-terminalpreparingandstartingstatuses, and resumed withrequire_existing_native_session, which Core sends only to recover a Turn whose native identity is unknown (execution/request.go). It now fails only on terminal statuses and resumes by native identity, as Core does.Test-only; both tests skip without their explicit live settings, so CI does not run them.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.