Repository navigation
Delete the workspace file read - #493
Merged
Merged
Conversation
Core never requested a byte read of a workspace file; only directory listing is called. Remove the file-read operation end to end: the gateway method, the wire fields operation, max_bytes, data and truncated, the dispatch reader branch, agent.WorkspaceReader and WorkspaceReadResult, the localworkspace, Claude, Codex and MiniMax Code implementations, and the Claude bridge's workspace_read feature. Directory selection returns a typed lister; a preparation handle is served only by the local workspace binding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
workspace_readcarried two operations: a byte-file read and a directory listing. Core never requests a file read:runtimegateway.Session.ReadWorkspaceFilehad no caller outside tests, and onlyListWorkspaceDirectoryis called (fromexecution/environment_directory.go). Every daemon path serving a file read was unreachable.Deleted end to end (about 860 lines net):
max_bytes,operation,dataandtruncated, andWorkspaceReadMaxBytes.operationwas alwaysdirectoryonce the file form is gone.proto.Versionstays 0.12.0.ReadWorkspaceFile, with one result validator left.agent.WorkspaceReaderandWorkspaceReadResult;localworkspaceReadWorkspaceFile; the Claude SDK read path (Go side, stdin frame, TSworkspace_reads.ts, theworkspace_readruntime feature); the Codex and MiniMax Code stubs.workspaceResourceLockedreturns aWorkspaceDirectoryListerinstead ofany. A preparation handle is served only by the local workspace binding (the only producer of a read-only preparation); the deadp.prepared/p.executor.nativeselection is gone.Directory listing is unchanged, and
workspace_readkeeps its name. Docs:docs/runtime-protocol.mdandharness-onboarding.md(+ zh).Checks:
-race -count=50on the changed concurrent tests; vet and gofmt; darwin/windows daemon builds.pnpm typecheckandnode --test(160/160).make check-names check-docs check-ci.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.