Drop rare Core installation modes - #401
Merged
Merged
Conversation
The installer now only sets up Core, Web and PostgreSQL in containers, and always saves the microsandbox Standard sandbox. Native Core, split deployments and the sandbox flags were unused combinations that the config model, bundle and operator docs all had to carry. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mode,native_core,ports.database,web.core_urlandoac apply --yes.--sandbox,--e2b-*,--accept-docker-risksand--core-key-fileare removed. Docker and E2B are chosen later in Web with Reset deployment.model_provider_sessions.pyis deleted. English and Chinese operator docs match.Test plan
python3 -m unittest discover -s deploy/install -p 'test_*.py'python3 scripts/core-distribution-manifest.test.pypython3 scripts/install-release.test.pypython3 scripts/config-reference.py --checkmake check-website(website dependencies are not installed in this worktree)install.shon a Linux host: sign in,oac status,oac apply,oac rotate-core-key--ingress externalinstallMade with Cursor
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.