Repository navigation
Add sandboxwire framing for the sandbox protocols - #335
Merged
Merged
Conversation
The File, Process and Link protocols share one 16-byte frame header, a primitive encoder and decoder that validates lengths and counts before allocating, tag classification, and the ID and Effect values more than one protocol uses. Each protocol's protocol.go owns its own messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
internal/sandboxwire: the 16-byte frame header, strict primitive encoder/decoder (zero-invalid enums, presence bytes, bounded counts, trailing-byte rejection) and the vocabulary shared by the File, Process and Link protocols (ID,Effect).Part of the agent-outside-sandbox M1 work on
feature/agent-outside-sandbox. No protocol uses it yet; the File, Process and Link lanes build on it.Checks:
go test ./internal/sandboxwire,go vet, gofmt,FuzzDecoder30 s, GOOS=darwin/windows builds.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.