Repository navigation
refactor: move node generation preparation into provider adapters - #288
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node generation construction inspected microsandbox configuration and invoked its native image CLI from the shared lifecycle. The registered adapter now owns lease preparation and image inspection; the node supplies a validated generation state directory through the common constructor contract. Explicit standalone construction preserves enrollment and single-provider execution.
Lease ownership, journal identity, probe ordering, bounded output and native error behavior remain covered by focused tests, including a real helper subprocess over test fixtures. A fresh independent reviewer found no blocking issues. Focused providers, sandbox-node and microsandbox tests, full Go build, affected vet and name guard passed; relevant tests were rerun after integrating the documentation consolidation. No live KVM acceptance or full
make checkwas run.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.