Repository navigation
fix(mcode): use the declared environment workspace - #244
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MiniMax workspace Sessions started the native process and ACP Session in the private history directory. The model consequently looked for prepared files there and wrote outputs outside the declared Environment workspace.
Use the validated Environment directory for native execution and ACP new/load, while retaining the existing Session data directory for configuration and history. This is confined to the MiniMax adapter; Core and the shared protocol are unchanged. Update the existing new/load process tests and the native workspace documentation.
Validation:
0f92d564-6556-4859-9153-7486801cfe79; private evidence on zju:~/.oac/acceptance/unified-environment-preparation-20260930/linux-minimax-fixed/turn-{1,2}-summary.json.check, official-client and native Linux/macOS/Windows jobs passed at1d5f9290. MiniMax remains unsupported on Windows.make checkpassed its initial gates, then stopped at an expired external sqlc path. With the existing pinned sqlc binary, daemon/shared Go, Core/API/database, Claude and frontend build/type checks passed; the additional remote Web browser run later finished with 84 passed and two failures (overview-readinesschart visibility and Chinese wording click timeout), so its subsequent example/companion targets were not reached. No Web files changed in this PR; the exact-head full CI passed all gates. These extra remote failures are recorded rather than presented as a green remote full gate.Existing Sessions created with the incorrect native cwd reject recovery after the cwd correction; create a new Session. Their files/history are retained. New Sessions support cold recovery. No deployment changes, history migration or data deletion.