Repository navigation
Stop passing retired executor transport configuration in the native no-environment test - #146
Merged
Merged
Conversation
…ment test Since #8 the daemon rejects a non-none CODEX_EXEC_SERVER_URL before setup, so TestNativeNoExecutionEnvironment failed at agent creation. The daemon's own retirement tests cover that rejection; the native test keeps its other caller overrides and proves the no-environment path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test-only fix.
TestNativeNoExecutionEnvironmenthas been broken since #8: it passedenv: {CODEX_EXEC_SERVER_URL}to the daemon, and the daemon now rejects that setting as retired executor transport configuration. This change removes that one option. The daemon's own tests already cover the rejection.Verification
b6888051: passed. Playwright browser cases were skipped on the server (Chrome unavailable; approved skip).Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.