Repository navigation
Follow the added node by its enrollment ID and say when node files are missing - #145
Merged
Merged
Conversation
SaladDay
force-pushed
the
codex/web-enrollment-id
branch
from
September 26, 2026 00:27
5dab52a to
a5fb909
Compare
…e missing Add node now follows only the node whose enrollment_id equals its command's, instead of guessing from the sandbox limits; a node enrolled before Core recorded the ID never matches. When /console/config lists node_artifacts without the deployment's provider (null reads as none, an absent field blocks nothing), the dialog says this console has no node files for it and issues no command. The host requirements no longer mention release downloads, and the not-connected hint explains that the node service keeps retrying until the node is removed.
SaladDay
added a commit
that referenced
this pull request
Sep 26, 2026
Core always sends enrollment_id on /core/v1/sandbox/nodes list and detail reads: a string, or null for nodes enrolled before Core recorded it. The client typed it as optional only until Web's fixtures included it (#145), so SandboxNode.enrollment_id is now a required string | null.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Web part F2a of phase 2 (one-command node add), following the backend's 2a (#144).
Changes
enrollment_idequals its command's. This replaces matching onmax_active/max_retained, which confused two valid commands with the same limits./console/config.node_artifactsdoesn't list the deployment's provider, the dialog says the console has no node files for it: install Core from the offline bundle, or add the release artifacts and rerun./install.sh. It offers no Generate and creates no token.Tests
node_artifactsparsing (absent, null, malformed, missing provider).node_artifacts: []) shows the message with no Generate and no writes.Results: typecheck ✓, agents-client 601, web 343, build ✓, full web e2e 28/28.
packages/agents-clientis unchanged; the TEMP stand-in was dropped.docs/web (already reviewed by the backend session)
protocol-coverage.md:124(Nodes) and:127(Enrollment).Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.