Repository navigation
Remove administrator asset copies and unused admin routes - #122
Merged
Merged
Conversation
Drop POST /core/v1/admin/copies with its store write paths and copy-only queries, and GET /core/v1/admin/startup-configuration and /runtime-history/capabilities. The console allowlist no longer forwards them. AdminClient loses copyResources, getRuntimeHistoryCapabilities, retrieveStartupConfiguration and the AdminCopy* types. Keep admin_resource_owners, which still reports source "admin_copy" for earlier copies, and admin_asset_copies under the no-drop rule. Historical copy audit entries keep their result_ids; new audit rows record none. The public /v1 startup-configuration and capability routes are unchanged. The admin acceptance script now runs its one real Turn on the source Project's own assets, revokes the creation key while that Turn runs, continues with a replacement key, and reads Session state for cleanup through the administrator route.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove administrator asset copying and the Core routes the Web no longer uses. This is part of the approved Core/Web boundary:
/core/v1serves only the Web console and operator scripts. The Web copy UI was removed in #116.Change
Removed routes:
POST /core/v1/admin/copies, along with every administrator copy write path, its queries and generated code;GET /core/v1/admin/startup-configuration;GET /core/v1/admin/runtime-history/capabilities.The matching
AdminClientmethods and types are removed too, and so is the console allowlist entry.History is kept: there is no migration and no table is dropped.
admin_resource_ownersstill feeds the historicalsource: "admin_copy"provenance read.admin_asset_copiesis kept only because tables are never dropped. Historical audit entries, including theirresult_ids, still list.Audit helper: it no longer takes copy mappings. New rows record
result_ids: [], and every remaining administrator write still commits its audit atomically.Acceptance script:
official_admin_management.pynow runs its single real-model Turn on the source Project's own assets. The creation key is revoked while the Turn runs, and the replacement key completes the Turn and writes. Isolation is checked in both directions. Cleanup goes through the administrator route.Unchanged: the public
/v1routes, including/v1/agents/core/startup-configuration, which a later batch removes. The public OpenAPI is unchanged.Validation
pnpm typecheckfor the whole repo, includingapps/web.run_model=false. The model Turn was not run for real, because no hosted Runtime was available; it compiles and imports under the pinned SDK.make check(server mode) passed on2f17fb3d. Playwright browser cases were skipped on the server (Chrome unavailable; user-approved skip).Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.