Repository navigation
Insights: remove the BIMI readiness check - #78
Merged
Merged
Conversation
bimi_ready failed on every email from a domain that published the DMARC
record our own setup recommends (p=none), so even a 10.0 report showed a
cross under Improvements. Its advice ended in a paid mark certificate for
Gmail (about US$800-1,750 a year), and a logo never changes delivery.
- Drop the check from the catalog and the engine; export CHECK_IDS.
- Stored reports are never rewritten, so readers keep only checks still
in the catalog: the insights lookup (email and broadcast pages,
GET /emails/{id}/insights) and the content-factors query (Metrics
score details, console safety page).
- SCORE_VERSION stays 1: the check weighed 0, so no score moves. The docs
now say a zero-weight check can be added or retired without a bump.
- Remove its en and pt-BR copy, the "unlocks BIMI" clause in the DMARC
record description, and the docs table rows.
- Factor-query fixtures use real catalog ids; tests pin that a retired
id is dropped while a zero-weight info check in the catalog stays.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
bimi_readydeliverability check. It was info-only (weight 0), but it failed on every email from a domain that published the DMARC record our own setup recommends (p=none), so even a 10.0 report showed a cross under Improvements. Its advice ended in a paid mark certificate for Gmail (about US$800–1,750 a year per domain), and a logo doesn't change where mail lands.Change
Engine (
packages/core/src/email-insights.ts): the check leavesCHECKSand the evaluator.CHECK_IDSis exported.Stored reports:
email_insightsrows are never rewritten, so readers keep only checks the catalog still has:fetchEmailInsights/fetchBroadcastInsights, behind the email and broadcast pages andGET /emails/{id}/insights;fetchContentFactors, behind Metrics score details and the console safety page (c->>'id' in (...), the catalog ids as parameters).Without this, older emails would keep the cross, or render a missing translation key once the copy is gone.
SCORE_VERSIONstays 1. The check weighed 0, so no score changes. The docs now say a zero-weight check can be added or retired without a version bump, and that a retired check disappears from older reports.Copy: the check's en and pt-BR strings are gone, and the DMARC record description no longer says enforcement "unlocks BIMI". The docs table rows are removed in both languages.
API
Reports from
GET /emails/{id}/insights, old and new, no longer includebimi_ready. The SDKs type check ids as an open set, so nothing breaks at compile time; a consumer that looked the id up by name now finds nothing.Verification
pnpm lint(the same 8 warnings asmain),pnpm typecheck, andpnpm test: 2,992 tests across 11 packages.bimi_ready, and the factors query skips it, while a failing zero-weight info check that is still in the catalog (images_offsite) stays in both. The factors fixtures now use real catalog ids instead of made-up ones.images_offsitefixtures above.🤖 Generated with Claude Code