CI: lint and format checks

.github/workflows/ci.yml

@@ -27,3 +27,17 @@ jobs:
       - run: pnpm typecheck
       - run: pnpm test
       - run: pnpm build
+
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4.4.0
+      - uses: pnpm/action-setup@f40ffcd9367d9f12939873eb1018b921a783ffaa # v4.3.0
+        with:
+          version: 9
+      - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
+        with:
+          node-version: 22
+          cache: pnpm
+      - run: pnpm install --frozen-lockfile
+      - run: pnpm lint

biome.json

@@ -0,0 +1,29 @@
+{
+  "$schema": "https://biomejs.dev/schemas/2.5.13/schema.json",
+  "vcs": {
+    "enabled": true,
+    "clientKind": "git",
+    "useIgnoreFile": true
+  },
+  "formatter": {
+    "enabled": true,
+    "indentStyle": "space",
+    "indentWidth": 2,
+    "lineWidth": 100
+  },
+  "linter": {
+    "enabled": true,
+    "rules": {
+      "preset": "recommended",
+      "suspicious": {
+        "noExplicitAny": "error"
+      }
+    }
+  },
+  "javascript": {
+    "formatter": {
+      "quoteStyle": "double",
+      "semicolons": "always"
+    }
+  }
+}

package.json

@@ -10,7 +10,15 @@
     "type": "git",
     "url": "git+https://github.com/MillionSend/millionsend-node.git"
   },
-  "keywords": ["millionsend", "resend", "email", "ses", "sdk", "transactional", "broadcast"],
+  "keywords": [
+    "millionsend",
+    "resend",
+    "email",
+    "ses",
+    "sdk",
+    "transactional",
+    "broadcast"
+  ],
   "exports": {
     ".": {
       "types": "./dist/index.d.ts",
@@ -20,17 +28,25 @@
   "main": "./dist/index.js",
   "module": "./dist/index.js",
   "types": "./dist/index.d.ts",
-  "files": ["dist", "README.md", "CHANGELOG.md", "LICENSE"],
+  "files": [
+    "dist",
+    "README.md",
+    "CHANGELOG.md",
+    "LICENSE"
+  ],
   "engines": {
     "node": ">=18"
   },
   "scripts": {
     "build": "tsc -p tsconfig.build.json",
     "typecheck": "tsc --noEmit",
     "test": "vitest run",
+    "lint": "biome check .",
+    "lint:fix": "biome check --write .",
     "prepack": "pnpm build"
   },
   "devDependencies": {
+    "@biomejs/biome": "2.5.13",
     "@types/node": "^22.20.1",
     "typescript": "^5.9.3",
     "vitest": "^3.2.4"

src/error.ts

@@ -20,7 +20,8 @@ export function toErrorResponse(body: unknown, status: number): ErrorResponse {
   if (body && typeof body === "object") {
     const b = body as Record<string, unknown>;
     const name = typeof b.name === "string" ? b.name : "application_error";
-    const message = typeof b.message === "string" ? b.message : `Request failed with status ${status}`;
+    const message =
+      typeof b.message === "string" ? b.message : `Request failed with status ${status}`;
     const statusCode = typeof b.statusCode === "number" ? b.statusCode : status;
     return { name, message, statusCode };
   }

src/http.ts

@@ -83,10 +83,11 @@ export class HttpClient {
 
   constructor(apiKey: string, options: MillionSendOptions = {}) {
     this.#apiKey = apiKey;
-    this.baseUrl = (options.baseUrl ?? process.env.MILLIONSEND_BASE_URL ?? DEFAULT_BASE_URL).replace(
-      /\/+$/,
-      "",
-    );
+    this.baseUrl = (
+      options.baseUrl ??
+      process.env.MILLIONSEND_BASE_URL ??
+      DEFAULT_BASE_URL
+    ).replace(/\/+$/, "");
     if (!options.allowInsecureHttp && isInsecureHttpUrl(this.baseUrl)) {
       throw new Error(
         `Refusing to send the API key over plain http to ${this.baseUrl}. Use https, or set allowInsecureHttp: true.`,

src/resources/contacts.ts

@@ -17,8 +17,8 @@ import type {
   CreateContactOptions,
   CreateContactsBatchOptions,
   List,
-  ListContactTopicsOptions,
   ListContactsOptions,
+  ListContactTopicsOptions,
   RemoveContactOptions,
   RemoveContactResponse,
   RemoveContactSegmentResponse,
@@ -162,7 +162,11 @@ export class Contacts {
   }
 
   update(options: UpdateContactOptions): Promise<Result<ContactId>> {
-    return this.http.request({ method: "PATCH", path: contactPath(options), body: updateBody(options) });
+    return this.http.request({
+      method: "PATCH",
+      path: contactPath(options),
+      body: updateBody(options),
+    });
   }
 
   /** DELETE /contacts/:id — `erase` also scrubs the address from email history (`?erase=true`). */

src/resources/emails.ts

@@ -110,7 +110,10 @@ export class Batch {
   constructor(private readonly http: HttpClient) {}
 
   /** POST /emails/batch — 1–100 emails in one call; supports an Idempotency-Key and `batchValidation`. */
-  send(payload: SendEmailOptions[], options: BatchRequestOptions = {}): Promise<Result<BatchResponse>> {
+  send(
+    payload: SendEmailOptions[],
+    options: BatchRequestOptions = {},
+  ): Promise<Result<BatchResponse>> {
     return this.http.request({
       method: "POST",
       path: "/emails/batch",
@@ -121,7 +124,10 @@ export class Batch {
   }
 
   /** Alias of {@link send}, mirroring Resend. */
-  create(payload: SendEmailOptions[], options: BatchRequestOptions = {}): Promise<Result<BatchResponse>> {
+  create(
+    payload: SendEmailOptions[],
+    options: BatchRequestOptions = {},
+  ): Promise<Result<BatchResponse>> {
     return this.send(payload, options);
   }
 }

src/resources/templates.ts

@@ -41,7 +41,10 @@ export class Templates {
   }
 
   get(idOrAlias: string): Promise<Result<Template>> {
-    return this.http.request({ method: "GET", path: `/templates/${encodeURIComponent(idOrAlias)}` });
+    return this.http.request({
+      method: "GET",
+      path: `/templates/${encodeURIComponent(idOrAlias)}`,
+    });
   }
 
   /** PATCH /templates/:idOrAlias — `alias`/`subject`/`text: null` clear the field. */

src/resources/topics.ts

@@ -39,7 +39,11 @@ export class Topics {
     return this.http.request({
       method: "PATCH",
       path: `/topics/${encodeURIComponent(id)}`,
-      body: { name: payload.name, description: payload.description, visibility: payload.visibility },
+      body: {
+        name: payload.name,
+        description: payload.description,
+        visibility: payload.visibility,
+      },
     });
   }
 

test/client.test.ts

@@ -67,7 +67,8 @@ describe("construction", () => {
     expect(() => new MillionSend("ms_test")).toThrow(/allowInsecureHttp/);
     delete process.env.MILLIONSEND_BASE_URL;
     expect(
-      () => new MillionSend("ms_test", { baseUrl: "http://mail.example.com", allowInsecureHttp: true }),
+      () =>
+        new MillionSend("ms_test", { baseUrl: "http://mail.example.com", allowInsecureHttp: true }),
     ).not.toThrow();
     expect(() => new MillionSend("ms_test", { baseUrl: "http://localhost:3001" })).not.toThrow();
     expect(() => new MillionSend("ms_test", { baseUrl: "http://127.0.0.1:3001" })).not.toThrow();
@@ -164,7 +165,11 @@ describe("request wiring", () => {
   it("passes the all_recipients_suppressed 422 through by name", async () => {
     const { ms } = makeClient({
       status: 422,
-      body: { statusCode: 422, name: "all_recipients_suppressed", message: "All recipients are suppressed" },
+      body: {
+        statusCode: 422,
+        name: "all_recipients_suppressed",
+        message: "All recipients are suppressed",
+      },
     });
     const res = await ms.emails.send({ from: "a@x.dev", to: "b@x.dev", subject: "s", text: "t" });
     expect(res.data).toBeNull();