Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Added the
on_health_failureplugin hook so plugins can react when a container becomes unhealthy after deployment.Closes #41
How
Verification
go build ./...go test ./...golangci-lint run ./...mctf generate --checkon the sample event (if derived files could change)docs/spec/, CHANGELOG) if behavior/CLI changedmake schemassynced (if on-disk shape changed)Notes
The health monitor uses Docker inspection to check container health, so containers without a Docker health check don't trigger the hook.
also, all tests related to our health-failure hook are passing :
but i got failures in internal/kubernetes. what appears to be failing :
The Kubernetes test failures appear unrelated to this change and were left untouched and i got them too while working on a previous issue. i'll fix them soon as a new issue