fix: replace console.log/error with NestJS Logger (#893) - #996
Merged
Conversation
- Add class-level Logger instances (RateLimitService, NotificationsService, EmailVerificationService, UsersControllerExample) using this.logger - Add module-level Logger instances for standalone functions (swagger.config.ts, validate-env.ts) - Set no-console ESLint rule to error Closes MettaChain#893
|
@abdoolyaro Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…ports - validate-env.ts: the merge from main kept the WEAK/JWT_SECRET_VARS/ MIN_JWT_SECRET_LENGTH declarations from MettaChain#892 but dropped the loop and error-reporting logic that used them, so weak JWT secrets were no longer actually being checked at startup. Restored that logic on top of the Logger-based error reporting from MettaChain#893. - examples.controller.ts: remove unused UseGuards and Query imports, now failing under --max-warnings=0.
nanaf6203-bit
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #893