Extended rms beamsize calculation #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions only. Added a parameter to specify the highest map order to be taken into account. Added a convenience function to return geometric and dispersive beamsize order-by-order.
ldeniau
approved these changes
Feb 12, 2026
Contributor
ldeniau
left a comment
ldeniau
left a comment
There was a problem hiding this comment.
Importing mtable is unnecessary since the object modules (including mtable) are loaded after the physics module. That’s why MAD.mtable must be used inside the function.
Regarding the physics part, I only notice an additional sqrt, which could just as well be handled on the user side. That said, it’s acceptable.
I’ll merge the PR, but I plan to apply a few adjustments afterward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended rms beamsize calculation by an estimate for geometric abberations only.
Added a parameter to specify the highest map order to be taken into account.
Added a convenience function to return geometric and dispersive beamsize order-by-order.