perf: implement caching to thumbnail render#18
Open
MichaelTj02 wants to merge 6 commits into
Open
Conversation
… and down scroll)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reworked thumbnail rendering pipeline and added queue-based caching saving previously rendered thumbnails outside of the viewport range. Fixed previous unstable rendering when scrolling up and down aggressively.
Type of change
How was this tested?
-Previously rendered thumbnails stays there. If cache exceeds size, check if thumbnail is deleted and re-rendered.
-See if aggressive scrolling crashes the app