Feat/stellar/enrichment client side

[khanti42]

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Medium Risk
Touches core AssetsController balance merge and account-tree refresh paths used by unified assets state; incorrect merging could affect displayed balances or metadata across chains, though the change is narrowly scoped to merge semantics and new-account fetching.

Overview
Extends the vendored @metamask/assets-controller Yarn patch so balance updates behave correctly with client-side Stellar trustline/metadata enrichment.

mergeAccountBalances no longer shallow-merges per account; for each asset id it merges into the existing balance object (defaulting amount to '0' when missing) so partial updates—e.g. enrichment writing metadata via handleAssetsUpdate with updateMode: 'merge'—are not wiped when a later fetch only supplies amount.

On account tree changes, the controller now tracks newly added accounts and, after the usual refresh, runs an extra getAssets for those accounts across all enabled chains, so multichain/Stellar balances populate when accounts are added without a full restart.

A small refactor in _AssetsController_handleAccountGroupChanged reuses a cached accounts variable when fetching balances for newly enabled chains (behavior unchanged).

^{Reviewed by Cursor Bugbot for commit 21fb2ca. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[khanti42]

this is an update of the patch to include this fix: MetaMask/core#9453

otherwise balance update drops metadata

[khanti42]

updated the snap to latest version by patching it

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	npm/​@​metamask/​eth-snap-keyring@​22.3.0 ⏵ 22.4.0	+1		+1	+2
	npm/​@​metamask/​keyring-api@​23.3.0 ⏵ 23.5.0	+1			+2
	npm/​@​metamask/​keyring-snap-client@​9.0.2 ⏵ 9.2.0	+1		+1	+5
	npm/​@​metamask/​assets-controller@​10.1.0 ⏵ 10.0.1
	npm/​@​metamask/​account-tree-controller@​7.5.3 ⏵ 7.5.4	+1		+1
	npm/​@​metamask/​assets-controllers@​109.3.0 ⏵ 109.2.1				+1

View full report

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeSwap, SmokeStake, SmokeWalletPlatform, SmokeMoney, SmokePerps, SmokeMultiChainAPI, SmokePredictions, SmokeSeedlessOnboarding, SmokeBrowser, SmokeSnaps
• Selected Performance tags: @PerformanceAssetLoading
• Risk Level: high
• AI Confidence: 100%

click to see 🤖 AI reasoning details

E2E Test Selection:
Hard rule (controller-version-update): @MetaMask controller package version updated in package.json: @metamask/assets-controllers, @metamask/assets-controller@npm:^10.0.1, @metamask/assets-controller. Running all tests.

Performance Test Selection:
The attachAccountAssetInfoFromBalances function is added to the selectAssetsBySelectedAccountGroup selector which runs on every state change for the main token list. This adds an additional iteration over all assets to re-attach metadata from balances. While the operation is O(n) and likely fast, it runs in a hot path (createDeepEqualSelector) that affects asset loading performance. The @metamask/assets-controller version change (downgrade with patch) could also affect balance fetching performance. @PerformanceAssetLoading covers token list rendering and balance fetching which are directly impacted by these selector changes.

View GitHub Actions results

[github-actions]

⚡ Performance Test Results

ℹ️ Performance test results are currently non-blocking and will not block this PR.

✅ All tests passed · 2 tests · 1 device

📱 Devices tested (1)

Android: Google Pixel 8 Pro (v14.0)

✅ Passed Tests (2)

Test	Platform	Device	Duration	Team	Recording
Aggregated Balance Loading Time, SRP 1 + SRP 2 + SRP 3	Android	Google Pixel 8 Pro (v14.0)	8.25s	@assets-dev-team	📹 Watch
Asset View, SRP 1 + SRP 2 + SRP 3	Android	Google Pixel 8 Pro (v14.0)	4.13s	@assets-dev-team	📹 Watch

---

Branch: feat/stellar/enrichment-client-side · Build: Normal · Commit: ccbc94c · View full run

[stanleyyconsensys]

this is by purpose, dont move it here

our plan is to remove asset enrich from old controller, and do it on new controller