test: organize Snap page objects - #45723
Open
hjetpoluru wants to merge 5 commits into
Open
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (2 files, +2 -2)
🫰 @MetaMask/core-platform (10 files, +29 -13)
🧪 @MetaMask/qa (7 files, +26 -10)
|
Contributor
Builds ready [bf983c1] [reused from 7a6956d]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 6 warn · 🔴 6 fail)
Bundle size diffs
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bf983c1. Configure here.
Contributor
Builds ready [d6b4cc7]
⚡ Performance Benchmarks (Total: 🟢 11 pass · 🟡 10 warn · 🔴 3 fail)
Bundle size diffs
|
hjetpoluru
enabled auto-merge
August 24, 2026 17:55
Contributor
Builds ready [9042d60]
⚡ Performance Benchmarks (Total: 🟢 10 pass · 🟡 10 warn · 🔴 3 fail)
Bundle size diffs
|
Contributor
Builds ready [9042d60]
⚡ Performance Benchmarks (Total: 🟢 10 pass · 🟡 10 warn · 🔴 3 fail)
Bundle size diffs
|
|
Contributor
Builds ready [37434c2]
⚡ Performance Benchmarks (Total: 🟢 15 pass · 🟡 6 warn · 🔴 3 fail)
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Group Snap-related page objects under pages/snaps, simplify redundant filenames, update imports, and add parent selectors for page-load checks.
Changelog
CHANGELOG entry: null
Related issues
Fixes:
https://consensyssoftware.atlassian.net/browse/MMQA-2251
Manual testing steps
CI should pass
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Test-only refactors and a non-functional UI test id; no production wallet or auth logic changes.
Overview
Reorganizes Snap-related e2e page objects into
test/e2e/page-objects/pages/snaps/with shorter filenames (list-page,simple-keyring-page,account-abstraction-keyring-page) and updates imports across Snap flows, account tests, and Flask user-operations specs.Adds page-load guards so tests wait for a stable root before interacting:
#gatsby-focus-wrapperon external Gatsby snap test sites (account abstraction and simple keyring), plus a newdata-testid="parent-selector-snap-list-page"on the extension Snaps list UI wired toSnapListPage.checkPageIsLoaded().Reviewed by Cursor Bugbot for commit 37434c2. Bugbot is set up for automated code reviews on this repo. Configure here.