Repository navigation
feat(tron): estimate send fees conservatively in onAmountInput - #554
Draft
ulissesferreira wants to merge 1 commit into
Draft
ulissesferreira wants to merge 1 commit into
ulissesferreira wants to merge 1 commit into
Conversation
ulissesferreira
force-pushed
the
WPN-2375-estimate-fees-conservatively-in-onamountinput
branch
from
November 4, 2026 16:51
a07d39c to
18d5846
Compare
2 of 4 tasks
|
ulissesferreira
changed the title
onAmountInput
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
onAmountInputreturned valid without checking fees whentoAddresswas absent. It now builds a probe transaction to the sender's own address and estimates fees, adding the account activation reserve for native TRX. TRC-20 transfers estimate the transfer fee without an activation reserve. This makes typing-time validation consistent with the destination-known case and preparesgetMaxSendableAmount.References
Ticket: WPN-2375
Checklist