Repository navigation
chore(stellar): drop RPC fallback for asset metadata enquiry - #505
Merged
stanleyyconsensys merged 6 commits intoOct 23, 2026
Merged
Conversation
stanleyyconsensys
requested
a balanced review from Copilot
and removed request for
a team
October 23, 2026 04:19
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Uncached classic assets can no longer complete send and trustline operations through handlers that require metadata resolution.
2 open issues
What changed in this PR
This PR makes Stellar asset metadata lookups use persisted metadata and the mainnet token API only, removing Horizon and Soroban RPC fallbacks.
Changes:
- Removes network metadata fetchers and contract metadata parsing.
- Simplifies service wiring, fixtures, and tests.
- Documents the behavior change and adjusts lint suppressions.
| File | Description |
|---|---|
packages/stellar-wallet-snap/src/utils/index.ts |
Removes an unused batching re-export. |
packages/stellar-wallet-snap/src/services/transaction/xdrParser.ts |
Removes contract metadata extraction. |
packages/stellar-wallet-snap/src/services/network/NetworkService.ts |
Removes Horizon and RPC metadata fetchers. |
packages/stellar-wallet-snap/src/services/network/NetworkService.test.ts |
Removes tests for deleted fetchers. |
packages/stellar-wallet-snap/src/services/network/api.ts |
Removes the metadata response type. |
packages/stellar-wallet-snap/src/services/asset-metadata/AssetMetadataService.ts |
Restricts uncached lookups to the mainnet token API. |
packages/stellar-wallet-snap/src/services/asset-metadata/AssetMetadataService.test.ts |
Updates mocks and API-miss expectations. |
packages/stellar-wallet-snap/src/services/asset-metadata/__mocks__/assets.fixtures.ts |
Removes network service construction. |
packages/stellar-wallet-snap/src/context.ts |
Removes the metadata service’s network dependency. |
packages/stellar-wallet-snap/CHANGELOG.md |
Adds the token-API-only change entry. |
eslint-suppressions.json |
Reduces obsolete test suppressions. |
Review effort: Balanced
|
stanleyyconsensys
enabled auto-merge
October 23, 2026 05:24
arafetbenmakhlouf
self-requested a review
October 23, 2026 05:42
arafetbenmakhlouf
approved these changes
Oct 23, 2026
stanleyyconsensys
deleted the
dev/stellar/drop-token-metadata-rpc-fallback
branch
October 23, 2026 05:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR drop the fallback of RPC and Horizon fetch asset metadata, as we have token api, and it is already done the same work
References
Checklist