[khanti42]

Explanation

Refactor: Confirmation Context Refreshers

• Core Change: Persist preference- and flow-enabled refresher keys at dialog open, then reuse that snapshot on MemoEdit Save so restarts do not re-fetch live preferences.
• Policy Alignment: Open and Save use the same ungated key set. Fetch-status gates stay in the refreshers (shouldFetch / recoveryResult no-op Error slices such as RequiresMemo) until Save resets status and restarts the chain.
• Utility Extraction: Extracted a shared resolveRefresherKeys utility that maps enable flags (enablePricing, enableSecurityScan, enableLocalSimulation) to refresher keys. It does not take fetch status.
• Controller/Handler Updates:
  • Persist and reuse resolved keys (refresherKeys) from the dialog-open snapshot.
  • Prevents preference drift between open and save paths.

References

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed
• I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

[Copilot]

Copilot review overview

🟡 Changes recommended

The open-path gates are lost, and late snapshot persistence creates a Save race.

Review effort: Balanced
Findings: 2

Open (2)

• Initial cron ignores open-path error status gates · New
• Late key snapshot causes Save to skip schedule restart · New

What changed in this PR

Unifies refresher-key resolution and reuses the dialog-open snapshot during MemoEdit saves.

Changes:

• Adds shared refresher-key resolution.
• Persists and reuses enabled refresher keys.
• Expands utility and MemoEdit tests.

File	Description
ui/​confirmation/​controller.tsx	Resolves, schedules, and persists refresher keys.
ui/​confirmation/​utils.ts	Adds the shared key resolver.
ui/​confirmation/​utils.test.ts	Tests resolver combinations.
ui/​confirmation/​api.ts	Adds refresher keys to confirmation context.
MemoEdit/​events.tsx	Restarts only snapshot-enabled refreshers.
MemoEdit/​events.test.tsx	Tests selective and disabled restarts.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[stanleyyconsensys]

nit:
we can use a superstruct to validate the context

const RestartRefreshContextStruct = type({
  transaction: string(),
  accountId: string(),
  transactionsFetchStatus: enums(Object.values(FetchStatus)),
  refresherKeys: array(enums(Object.values(ConfirmationContextRefresherKey))),
  scope: KnownCaip2ChainIdStruct
})
export type RestartRefreshContext = Infer<typeof RestartRefreshContextStruct>;

canRestartRefresh(context: unknown): asserts context is RestartRefreshContext   {
  RestartRefreshContextStruct.is(context)
}

[Copilot]

🟡 Changes recommended

Memo saves can enable confirmation before revalidation completes, and save failures can restore stale validation state.

3 open issues

• Use the same ungated refresher keys for Open and Save · New
• Keep confirmation blocked until restarted local validation succeeds · New
• Preserve the latest base context when rendering save errors · New

2 resolved since last review

• Late key snapshot causes Save to skip schedule restart
• Initial cron ignores open-path error status gates

_{Review effort: Balanced}

[sonarqubecloud]

Quality Gate failed

Failed conditions
40.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud