feat(stellar): fetch live data in keyring `listAccountAssets` and `getAccountBalances` + read balance data from `AssetsController` + stop account sync while Asset migration is on by stanleyyconsensys · Pull Request #331 · MetaMask/internal-snaps

stanleyyconsensys · 2026-09-21T06:38:13Z

Explanation

Keyring listAccountAssets and getAccountBalances read live holdings from AssetsController when the Stellar asset migration is on.

Account synchronization is skipped only while that migration is on. AssetsController owns fungible holdings in that mode, so the snap does not persist on-chain account snapshots or emit keyring balance events. When migration is off, account sync still runs against snap state.

References

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've communicated my changes to consumers by updating changelogs for packages I've changed
I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Copilot

Copilot review overview

🟡 Changes recommended

There are confirmed blocking issues that force migration behavior on unconditionally and bypass the intended migration guard when backfilling the catalog, plus a formatting issue likely to fail lint/format checks.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 · 1 · 2

Open (4)

Feature flag is always enabled · New
Bypassing synchronize ignores migration guard · New
Fix inconsistent file indentation · New
Fix typo: Possiblly to Possibly · New

What changed in this PR

Adds initial “Core assets migration” plumbing for the Stellar snap so that (when a remote flag enables it) holdings and catalog metadata can be read from Core’s AssetsController instead of snap state, while still allowing fallback to existing snap persistence where needed.

Changes:

Introduces AssetsService + CoreAssetsAdapter and wires Core messenger/endowments to fetch account assets and asset metadata.
Updates on-chain account resolution/sync to optionally bind balances from Core assets and (optionally) overlay account ledger meta from Soroban RPC.
Extends network layer with getAccountLedgerMeta and adds additional validation helpers for Stellar int64-like values.

File	Description
yarn.lock	Adds Core migration-related dependencies for the Stellar snap workspace.
packages/stellar-wallet-snap/src/services/on-chain-account/utils.ts	Makes minimum-balance calc use a named constant; adds helper to invert minimum reserve into subentry count.
packages/stellar-wallet-snap/src/services/on-chain-account/utils.test.ts	Adds tests for `subentryCountFromMinimumReserveStroops`.
packages/stellar-wallet-snap/src/services/on-chain-account/OnChainAccountService.ts	Adds Core-backed account resolution and skips snap-state sync when migration is enabled.
packages/stellar-wallet-snap/src/services/on-chain-account/OnChainAccountService.test.ts	Adds tests for Core-backed account resolution and migration-enabled sync skip.
packages/stellar-wallet-snap/src/services/on-chain-account/__mocks__/onChainAccount.fixtures.ts	Wires `AssetsService` into on-chain account service test fixture.
packages/stellar-wallet-snap/src/services/network/NetworkService.ts	Adds `getAccountLedgerMeta` via Soroban RPC `getAccountEntry`.
packages/stellar-wallet-snap/src/services/network/NetworkService.test.ts	Adds unit tests for `getAccountLedgerMeta` success/error paths.
packages/stellar-wallet-snap/src/services/network/api.ts	Adds `AccountLedgerMeta` type for RPC-derived account fields.
packages/stellar-wallet-snap/src/services/assets/utils.ts	Adds migration-flag helper (currently with a blocking issue noted in comments).
packages/stellar-wallet-snap/src/services/assets/index.ts	Exposes new assets facade, adapter, parsing helpers, and migration util.
packages/stellar-wallet-snap/src/services/assets/AssetsService.ts	Adds Core AssetsController facade with parsing/validation of Core payloads.
packages/stellar-wallet-snap/src/services/assets/AssetsService.test.ts	Adds tests for catalog metadata parsing and account-asset validation behavior.
packages/stellar-wallet-snap/src/services/assets/api.ts	Defines superstruct validation for Core “Stellar-shaped” asset rows/metadata.
packages/stellar-wallet-snap/src/services/assets/api.test.ts	Adds tests for the Core asset validation/parsing helpers.
packages/stellar-wallet-snap/src/services/assets/adapters/CoreAssetsAdapter.ts	Implements adapter over `AssetsProvider` calls (account assets + metadata).
packages/stellar-wallet-snap/src/services/assets/__mocks__/assetsService.fixtures.ts	Adds AssetsService test fixture with mocked adapter + feature flag values.
packages/stellar-wallet-snap/src/services/asset-metadata/utils.ts	Allows overriding icon URL (e.g., from Core metadata image).
packages/stellar-wallet-snap/src/services/asset-metadata/AssetMetadataService.ts	Adds Core metadata lookup path + migration-enabled sync skip (with one bypass issue noted in comments).
packages/stellar-wallet-snap/src/services/asset-metadata/AssetMetadataService.test.ts	Adds tests for migration-enabled sync skip and Core-first metadata resolution.
packages/stellar-wallet-snap/src/services/asset-metadata/__mocks__/assets.fixtures.ts	Wires AssetsService into asset-metadata service mock fixture.
packages/stellar-wallet-snap/src/handlers/keyring/keyring.ts	Updates call to `resolveOnChainAccountByKeyringAccountId` with account address.
packages/stellar-wallet-snap/src/handlers/clientRequest/onAmountInput.test.ts	Updates expectations for the new `resolveOnChainAccountByKeyringAccountId` signature.
packages/stellar-wallet-snap/src/handlers/accountResolver.ts	Updates call to `resolveOnChainAccountByKeyringAccountId` with account address.
packages/stellar-wallet-snap/src/handlers/accountResolver.test.ts	Updates expectations for the new `resolveOnChainAccountByKeyringAccountId` signature.
packages/stellar-wallet-snap/src/context.ts	Wires Core messenger providers + adapter/service and injects into dependent services.
packages/stellar-wallet-snap/src/constants.ts	Adds `ACCOUNT_MINIMUM_BASE_RESERVE_UNIT` constant for minimum-balance math.
packages/stellar-wallet-snap/src/api/integer.ts	Fixes max-int comparison usage and adds `ValidStellarInt64Struct`.
packages/stellar-wallet-snap/src/api/integer.test.ts	Adds tests for `ValidStellarInt64Struct`.
packages/stellar-wallet-snap/src/api/core-messenger.ts	Defines types/actions namespace for Core messenger endowment (formatting issue noted in comments).
packages/stellar-wallet-snap/snap.manifest.json	Adds `endowment:messenger` actions for feature flag + assets controller reads.
packages/stellar-wallet-snap/package.json	Adds devDependencies needed for Core messenger + assets controller integration.
packages/snap-networks-utils/src/providers/assets/AssetsProvider.ts	Adds AssetsController `getAssetMetadata` action support.
packages/snap-networks-utils/src/providers/assets/AssetsProvider.test.ts	Adds test for `AssetsProvider.getAssetMetadata`.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

socket-security · 2026-10-15T04:39:51Z

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

…stellar/asset-migration

Copilot

🟡 Changes recommended

Critical and moderate issues remain in network scoping, cache defaults, balance preservation, synchronization gating, and balance-limit normalization.

5 open issues

Use the intended 30-second default TTL · New
Restrict asset balance queries to the selected network · New
Preserve sponsored-account spendable balance during migration · New
Document support for classic asset IDs · New
Update synchronization docs for the new asset flow · New

_{Review effort: Lite}

Copilot

🔵 Needs a closer look

Resolve the stale SEP-41 catalog refresh and uncached balance lookup issues, and correct the changelog wording.

No open issues 🎉

1 previously missed issue

In code that hasn't changed since last review

Correct migration guard behavior in PR description

packages/stellar-wallet-snap/src/services/on-chain-account/OnChainAccountService.ts:493

The PR title says account synchronization stops while Asset migration is off, but this guard skips synchronization only when isMigrationEnabled() is true; the surrounding implementation and tests describe the opposite behavior. Please correct the title/description if migration-on is intended, or revisit the guard if migration-off is the requirement.

5 resolved since last review

_{Review effort: Lite}

Copilot

🔵 Needs a closer look

Resolve the two moderate cache and stale-catalog issues; also correct the changelog typo.

No open issues 🎉

_{Review effort: Lite}

stanleyyconsensys · 2026-10-23T07:09:29Z

  ): Promise<Sep41StellarAssetMetadata[]> {
    try {
-      return await this.#assetMetadataService.fetchSep41AssetsOrSyncOnce(scope);
+      await this.#assetMetadataService.synchronizeIfStale(scope);


this is the same as b4, just split into 2 method to more explicit

stanleyyconsensys · 2026-10-23T07:53:11Z

-   * @param scope - The chain ID to look up.
-   * @returns A Promise that resolves to all persisted SEP-41 assets for the given chain ID.
-   */
-  async getPersistedSep41AssetsMetadata(


rename to getAssetsByScopeAndType

ulissesferreira · 2026-10-23T09:17:41Z

praise: nice one!

Updated changelog to clarify asset balance reading conditions and included SEP-41 balances. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

sonarqubecloud · 2026-10-23T14:52:10Z

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

stanleyyconsensys added 5 commits September 8, 2026 11:54

chore: remove dead code getAssetsMetadataByAssetIds

7202278

Merge branch 'main' into dev/stellar/asset-migration

e20696a

Merge branch 'main' into dev/stellar/asset-migration

201eb4e

chore: add asset migration

ec2a57a

chore: update code

2a59e1d

stanleyyconsensys requested review from a team as code owners September 21, 2026 06:38

stanleyyconsensys marked this pull request as draft September 21, 2026 06:38

stanleyyconsensys deployed to default-branch September 21, 2026 06:38 — with GitHub Actions Active

chore: update package

5cb3757

stanleyyconsensys requested a lite review from Copilot September 21, 2026 06:55

Copilot started reviewing on behalf of stanleyyconsensys September 21, 2026 06:56

View session

Copilot AI reviewed Sep 21, 2026

View reviewed changes

stanleyyconsensys added 14 commits September 23, 2026 15:36

Merge branch 'main' into dev/stellar/asset-migration

80f60a7

fix: lint

3f25320

Merge branch 'main' into dev/stellar/asset-migration

e7843a2

chore: add life data for resolve onChain Account

54164d5

chore: get live data from keyring method

63d52c3

Merge branch 'main' into dev/stellar/asset-migration

0f34fd9

fix: rename

14d3591

fix: setSep41BalanceForAccount

aee1799

Merge branch 'main' into dev/stellar/asset-migration

48ddba5

fix: lint and test

e92e082

Merge branch 'main' into dev/stellar/asset-migration

576442f

Merge branch 'main' into dev/stellar/asset-migration

346ea10

chore: update service

119fefe

Merge branch 'main' into dev/stellar/asset-migration

d132073

stanleyyconsensys added 2 commits October 15, 2026 15:10

Delete utils.ts

0a960c2

chore: update

1e54092

stanleyyconsensys added 8 commits October 23, 2026 12:26

Update CHANGELOG.md

30f02bd

Merge branch 'main' into dev/stellar/drop-token-metadata-rpc-fallback

17c138b

Update CHANGELOG.md

eb81989

fix: comment

19963ad

Merge branch 'dev/stellar/drop-token-metadata-rpc-fallback' into dev/…

bd43de1

…stellar/asset-migration

Merge branch 'dev/stellar/drop-token-metadata-rpc-fallback' into dev/…

cd67ed9

…stellar/asset-migration

Merge branch 'main' into dev/stellar/asset-migration

fdc31dd

chore: cache 5 second only

2d6d8b7

stanleyyconsensys requested a lite review from Copilot October 23, 2026 06:23

Copilot started reviewing on behalf of stanleyyconsensys October 23, 2026 06:23

View session

Update config.test.ts

735fe9e

Copilot AI reviewed Oct 23, 2026

View reviewed changes

stanleyyconsensys added 3 commits October 23, 2026 14:32

Update config.test.ts

d4357c3

chore: update doc

2f05b41

fix: comment

cf48e48

stanleyyconsensys requested a lite review from Copilot October 23, 2026 06:46

Copilot started reviewing on behalf of stanleyyconsensys October 23, 2026 06:47

View session

Update utils.test.ts

9a0f040

Copilot AI reviewed Oct 23, 2026

View reviewed changes

stanleyyconsensys requested a lite review from Copilot October 23, 2026 07:03

Copilot started reviewing on behalf of stanleyyconsensys October 23, 2026 07:03

View session

Copilot AI reviewed Oct 23, 2026

View reviewed changes

stanleyyconsensys commented Oct 23, 2026

View reviewed changes

ulissesferreira reviewed Oct 23, 2026

View reviewed changes

Comment thread packages/stellar-wallet-snap/src/constants.ts

ulissesferreira Oct 23, 2026

Copy link
Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: nice one!

ulissesferreira previously approved these changes Oct 23, 2026

View reviewed changes

Clarify asset balance reading in changelog

e6e4f27

Updated changelog to clarify asset balance reading conditions and included SEP-41 balances. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

stanleyyconsensys dismissed ulissesferreira’s stale review via e6e4f27 October 23, 2026 14:47

Conversation

stanleyyconsensys commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation

References

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

socket-security Bot commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

stanleyyconsensys Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

stanleyyconsensys Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

ulissesferreira Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Oct 23, 2026

Quality Gate passed

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

stanleyyconsensys commented Sep 21, 2026 •

edited

Loading

socket-security Bot commented Oct 15, 2026 •

edited

Loading