feat(stellar): fetch live data in keyring `listAccountAssets` and `getAccountBalances` + read balance data from `AssetsController` + stop account sync while Asset migration is off by stanleyyconsensys · Pull Request #331 · MetaMask/internal-snaps

stanleyyconsensys · 2026-09-21T06:38:13Z

Explanation

References

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've communicated my changes to consumers by updating changelogs for packages I've changed
I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Copilot

Copilot review overview

🟡 Changes recommended

There are confirmed blocking issues that force migration behavior on unconditionally and bypass the intended migration guard when backfilling the catalog, plus a formatting issue likely to fail lint/format checks.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 · 1 · 2

Open (4)

Feature flag is always enabled · New
Bypassing synchronize ignores migration guard · New
Fix inconsistent file indentation · New
Fix typo: Possiblly to Possibly · New

What changed in this PR

Adds initial “Core assets migration” plumbing for the Stellar snap so that (when a remote flag enables it) holdings and catalog metadata can be read from Core’s AssetsController instead of snap state, while still allowing fallback to existing snap persistence where needed.

Changes:

Introduces AssetsService + CoreAssetsAdapter and wires Core messenger/endowments to fetch account assets and asset metadata.
Updates on-chain account resolution/sync to optionally bind balances from Core assets and (optionally) overlay account ledger meta from Soroban RPC.
Extends network layer with getAccountLedgerMeta and adds additional validation helpers for Stellar int64-like values.

File	Description
yarn.lock	Adds Core migration-related dependencies for the Stellar snap workspace.
packages/stellar-wallet-snap/src/services/on-chain-account/utils.ts	Makes minimum-balance calc use a named constant; adds helper to invert minimum reserve into subentry count.
packages/stellar-wallet-snap/src/services/on-chain-account/utils.test.ts	Adds tests for `subentryCountFromMinimumReserveStroops`.
packages/stellar-wallet-snap/src/services/on-chain-account/OnChainAccountService.ts	Adds Core-backed account resolution and skips snap-state sync when migration is enabled.
packages/stellar-wallet-snap/src/services/on-chain-account/OnChainAccountService.test.ts	Adds tests for Core-backed account resolution and migration-enabled sync skip.
packages/stellar-wallet-snap/src/services/on-chain-account/__mocks__/onChainAccount.fixtures.ts	Wires `AssetsService` into on-chain account service test fixture.
packages/stellar-wallet-snap/src/services/network/NetworkService.ts	Adds `getAccountLedgerMeta` via Soroban RPC `getAccountEntry`.
packages/stellar-wallet-snap/src/services/network/NetworkService.test.ts	Adds unit tests for `getAccountLedgerMeta` success/error paths.
packages/stellar-wallet-snap/src/services/network/api.ts	Adds `AccountLedgerMeta` type for RPC-derived account fields.
packages/stellar-wallet-snap/src/services/assets/utils.ts	Adds migration-flag helper (currently with a blocking issue noted in comments).
packages/stellar-wallet-snap/src/services/assets/index.ts	Exposes new assets facade, adapter, parsing helpers, and migration util.
packages/stellar-wallet-snap/src/services/assets/AssetsService.ts	Adds Core AssetsController facade with parsing/validation of Core payloads.
packages/stellar-wallet-snap/src/services/assets/AssetsService.test.ts	Adds tests for catalog metadata parsing and account-asset validation behavior.
packages/stellar-wallet-snap/src/services/assets/api.ts	Defines superstruct validation for Core “Stellar-shaped” asset rows/metadata.
packages/stellar-wallet-snap/src/services/assets/api.test.ts	Adds tests for the Core asset validation/parsing helpers.
packages/stellar-wallet-snap/src/services/assets/adapters/CoreAssetsAdapter.ts	Implements adapter over `AssetsProvider` calls (account assets + metadata).
packages/stellar-wallet-snap/src/services/assets/__mocks__/assetsService.fixtures.ts	Adds AssetsService test fixture with mocked adapter + feature flag values.
packages/stellar-wallet-snap/src/services/asset-metadata/utils.ts	Allows overriding icon URL (e.g., from Core metadata image).
packages/stellar-wallet-snap/src/services/asset-metadata/AssetMetadataService.ts	Adds Core metadata lookup path + migration-enabled sync skip (with one bypass issue noted in comments).
packages/stellar-wallet-snap/src/services/asset-metadata/AssetMetadataService.test.ts	Adds tests for migration-enabled sync skip and Core-first metadata resolution.
packages/stellar-wallet-snap/src/services/asset-metadata/__mocks__/assets.fixtures.ts	Wires AssetsService into asset-metadata service mock fixture.
packages/stellar-wallet-snap/src/handlers/keyring/keyring.ts	Updates call to `resolveOnChainAccountByKeyringAccountId` with account address.
packages/stellar-wallet-snap/src/handlers/clientRequest/onAmountInput.test.ts	Updates expectations for the new `resolveOnChainAccountByKeyringAccountId` signature.
packages/stellar-wallet-snap/src/handlers/accountResolver.ts	Updates call to `resolveOnChainAccountByKeyringAccountId` with account address.
packages/stellar-wallet-snap/src/handlers/accountResolver.test.ts	Updates expectations for the new `resolveOnChainAccountByKeyringAccountId` signature.
packages/stellar-wallet-snap/src/context.ts	Wires Core messenger providers + adapter/service and injects into dependent services.
packages/stellar-wallet-snap/src/constants.ts	Adds `ACCOUNT_MINIMUM_BASE_RESERVE_UNIT` constant for minimum-balance math.
packages/stellar-wallet-snap/src/api/integer.ts	Fixes max-int comparison usage and adds `ValidStellarInt64Struct`.
packages/stellar-wallet-snap/src/api/integer.test.ts	Adds tests for `ValidStellarInt64Struct`.
packages/stellar-wallet-snap/src/api/core-messenger.ts	Defines types/actions namespace for Core messenger endowment (formatting issue noted in comments).
packages/stellar-wallet-snap/snap.manifest.json	Adds `endowment:messenger` actions for feature flag + assets controller reads.
packages/stellar-wallet-snap/package.json	Adds devDependencies needed for Core messenger + assets controller integration.
packages/snap-networks-utils/src/providers/assets/AssetsProvider.ts	Adds AssetsController `getAssetMetadata` action support.
packages/snap-networks-utils/src/providers/assets/AssetsProvider.test.ts	Adds test for `AssetsProvider.getAssetMetadata`.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

socket-security · 2026-10-15T04:39:51Z

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

…tellar/asset-migration

Copilot

🟡 Changes recommended

Unresolved critical and moderate issues affect migrated account correctness, source selection, state safety, and secret handling.

4 open issues

Preserve the live sequence number in migrated accounts · New
Use migration-aware account source for asset reads · New
Fix typo in changelog entry · New
Fix Asset parameter description typo · New

4 resolved since last review

_{Review effort: Lite}

Copilot

🟡 Changes recommended

Unresolved critical fixture security and network-safety issues, plus trustline and balance correctness issues, remain.

3 open issues

Ignore plaintext Horizon fixture secrets · New
Reject non-pubnet CAIP asset IDs · New
Correct missing is in gated sentence · New

1 previously missed issue

In code that hasn't changed since last review

Preserve trustline sponsors in classic balances

packages/stellar-wallet-snap/src/services/on-chain-account/OnChainAccountService.ts:481

The AssetsController classic balance metadata includes the trustline sponsor, but this mapping drops it before creating the serializable balance. As a result, migrated sponsored trustlines are returned by keyring APIs without their sponsor address, unlike Horizon-backed accounts. Preserve the non-empty sponsor when building the serialized entry.

4 resolved since last review

_{Review effort: Lite}

stanleyyconsensys · 2026-10-22T08:21:38Z


-    // If the account is not activated or not yet synced, return the native asset with zero balance
+    // TDOO: remove this gate after asset migration is fully enabled.
+    if (enableAssetMigration) {


this is to maintain the same experience of stellar, incase, there are some hot fix need to ship, we wont ship some major behavior change to client

especially this will increase the network call when we unblock it

sonarqubecloud · 2026-10-22T09:10:44Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copilot

🟡 Changes recommended

The classic trustline sponsor metadata issue and documented typos remain unresolved.

2 open issues

Preserve trustline sponsor in account balance mapping · New
Correct TDOO typo in TODO comment · New

3 resolved since last review

_{Review effort: Lite}

+            limit,
+            address,
+            authorized,
+            sponsored,


+    let onChainAccount: OnChainAccount | null = null;

-    // If the account is not activated or not yet synced, return the native asset with zero balance
+    // TDOO: remove this gate after asset migration is fully enabled.


stanleyyconsensys added 5 commits September 8, 2026 11:54

chore: remove dead code getAssetsMetadataByAssetIds

7202278

Merge branch 'main' into dev/stellar/asset-migration

e20696a

Merge branch 'main' into dev/stellar/asset-migration

201eb4e

chore: add asset migration

ec2a57a

chore: update code

2a59e1d

stanleyyconsensys requested review from a team as code owners September 21, 2026 06:38

stanleyyconsensys marked this pull request as draft September 21, 2026 06:38

stanleyyconsensys deployed to default-branch September 21, 2026 06:38 — with GitHub Actions Active

chore: update package

5cb3757

stanleyyconsensys requested a lite review from Copilot September 21, 2026 06:55

Copilot started reviewing on behalf of stanleyyconsensys September 21, 2026 06:56

View session

Copilot AI reviewed Sep 21, 2026

View reviewed changes

stanleyyconsensys added 14 commits September 23, 2026 15:36

Merge branch 'main' into dev/stellar/asset-migration

80f60a7

fix: lint

3f25320

Merge branch 'main' into dev/stellar/asset-migration

e7843a2

chore: add life data for resolve onChain Account

54164d5

chore: get live data from keyring method

63d52c3

Merge branch 'main' into dev/stellar/asset-migration

0f34fd9

fix: rename

14d3591

fix: setSep41BalanceForAccount

aee1799

Merge branch 'main' into dev/stellar/asset-migration

48ddba5

fix: lint and test

e92e082

Merge branch 'main' into dev/stellar/asset-migration

576442f

Merge branch 'main' into dev/stellar/asset-migration

346ea10

chore: update service

119fefe

Merge branch 'main' into dev/stellar/asset-migration

d132073

stanleyyconsensys added 2 commits October 15, 2026 15:10

Delete utils.ts

0a960c2

chore: update

1e54092

stanleyyconsensys added 6 commits October 22, 2026 09:47

Update CHANGELOG.md

1fc0615

Update CHANGELOG.md

6de375c

Merge branch 'dev/stellar/trustline-keyring-balance-limit' into dev/s…

1a31377

…tellar/asset-migration

chore: update keyring

83f312f

fix: lint

ac05404

fix: lint

f63fead

stanleyyconsensys requested a lite review from Copilot October 22, 2026 05:00

Copilot started reviewing on behalf of stanleyyconsensys October 22, 2026 05:01

View session

Copilot AI reviewed Oct 22, 2026

View reviewed changes

fix: comment

a422f72

stanleyyconsensys requested a lite review from Copilot October 22, 2026 06:25

Copilot started reviewing on behalf of stanleyyconsensys October 22, 2026 06:26

View session

Copilot AI reviewed Oct 22, 2026

View reviewed changes

Comment thread packages/stellar-wallet-snap/scripts/horizon-event-fixture.mjs Outdated

Comment thread packages/stellar-wallet-snap/scripts/horizon-event-fixture.mjs Outdated

Comment thread packages/stellar-wallet-snap/src/handlers/keyring/keyring.ts Outdated

stanleyyconsensys added 2 commits October 22, 2026 14:39

fix: rename method

a8cdc55

Merge branch 'main' into dev/stellar/asset-migration

0988a17

stanleyyconsensys changed the title ~~feat(stellar): asset migration~~ feat(stellar): return live data in keyring listAccountAssets and getAccountBalances but gate by local config enableAssetMigration Oct 22, 2026

stanleyyconsensys marked this pull request as ready for review October 22, 2026 07:55

stanleyyconsensys deployed to default-branch October 22, 2026 07:56 — with GitHub Actions Active

khanti42 previously approved these changes Oct 22, 2026

View reviewed changes

stanleyyconsensys requested a review from khanti42 October 22, 2026 08:16

stanleyyconsensys commented Oct 22, 2026

View reviewed changes

Merge branch 'main' into dev/stellar/asset-migration

9f9e515

stanleyyconsensys dismissed khanti42’s stale review via 9f9e515 October 22, 2026 09:04

stanleyyconsensys requested a review from a team as a code owner October 22, 2026 09:04

Delete horizon-event-fixture.mjs

853c070

Julink-eth requested a lite review from Copilot October 22, 2026 09:08

Copilot started reviewing on behalf of Julink-eth October 22, 2026 09:08

View session

Copilot AI reviewed Oct 22, 2026

View reviewed changes

Navigation Menu

Repository navigation

feat(stellar): fetch live data in keyring `listAccountAssets` and `getAccountBalances` + read balance data from `AssetsController` + stop account sync while Asset migration is off - #331

feat(stellar): fetch live data in keyring `listAccountAssets` and `getAccountBalances` + read balance data from `AssetsController` + stop account sync while Asset migration is off#331
stanleyyconsensys wants to merge 52 commits into
mainfrom
dev/stellar/asset-migration

stanleyyconsensys commented Sep 21, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

socket-security Bot commented Oct 15, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stanleyyconsensys Oct 22, 2026

Uh oh!

sonarqubecloud Bot commented Oct 22, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

stanleyyconsensys commented Sep 21, 2026

Explanation

References

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

socket-security Bot commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stanleyyconsensys Oct 22, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Oct 22, 2026

Quality Gate passed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

socket-security Bot commented Oct 15, 2026 •

edited

Loading