fix: gate Money Account payment override prepend to same-chain flows

[OGPoyraz]

Explanation

Cross-chain Money Account deposits — e.g. a Predict (Polymarket) withdrawal on Polygon that deposits into a Money Account on Monad — failed on the Relay /execute step with the custom error InvalidEOASignature() (selector 0x3db6791c).

Current state: submitTransactions unconditionally prepends the Money Account payment override onto the source-chain execute batch whenever quote.request.paymentOverride is set. For a cross-chain deposit, the payment override is a Money Account deposit delegation that belongs on the destination chain — it is already carried in the Relay quote's destination txs[], and its delegation is EIP-712 signed for the destination chainId. Prepending it onto the source-chain batch caused that destination-signed delegation to be redeemed on the source chain, so redeemDelegations → executeFromExecutor validated the signature with the source chain's domain, recovered a different signer, and the EIP7702StatelessDeleGator reverted with InvalidEOASignature().

Solution: Only prepend the payment override onto the source execute batch for same-chain flows (currencyIn.chainId === currencyOut.chainId). For cross-chain flows we fall through to the existing post-quote path, which prepends the original transaction (e.g. the Predict withdrawal); the Money Account deposit continues to run on the destination side via the quote's txs[].

The change is a one-line guard (&& isSameChainOverride) plus a comment explaining the invariant.

Proof

Before the fix, the Relay /execute simulation returned (decoded revert trace):

Multicall3.aggregate3Value
└─ redeemDelegations                @ 0xdb9b1e94… (DelegationManager, source chain 137)
   └─ executeFromExecutor           @ 0x6d404afe… (7702 account)
      └─ redeemDelegations          @ 0xdb9b1e94…
         └─ revert 0x3db6791c = InvalidEOASignature()

The delegation being redeemed was signed for the destination chain (Monad, chainId 143) but executed on the source chain (Polygon, chainId 137) — confirmed via signDelegation logs showing domain.chainId: 143 for the Money Account delegation while the execute body used data.chainId: 137.

After the fix, the cross-chain source batch no longer contains the destination-signed override, so the InvalidEOASignature() revert no longer occurs.

References

• CONF-1525

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed
• I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

---

Note

Medium Risk
Touches Relay submit batch composition for paymentOverride flows; wrong gating could break same-chain Money Account deposits or leave cross-chain paths unchanged.

Overview
Fixes cross-chain Money Account deposits (e.g. Predict withdraw on Polygon → Money Account on another chain) failing Relay /execute with InvalidEOASignature() by changing when the Money Account payment override is injected into the source-chain batch.

submitTransactions in relay-submit.ts now prepends override calls from getPaymentOverrideData only when paymentOverride is set and currencyIn.chainId === currencyOut.chainId. For cross-chain quotes, the override delegation is already on the destination txs[] and is EIP-712 signed for the destination chain; putting it on the source batch caused wrong-domain signature recovery. Cross-chain flows skip the override prepend (and getPaymentOverrideData) and use the existing post-quote behavior (e.g. prepend the original withdraw tx).

Tests align same-chain override cases and add coverage that cross-chain flows do not call getPaymentOverrideData. Changelog updated under Fixed.

^{Reviewed by Cursor Bugbot for commit cc17bcb. Bugbot is set up for automated code reviews on this repo. Configure here.}