feat(Stellar): asset enrichment through snap data source by khanti42 · Pull Request #9422 · MetaMask/core

khanti42 · 2026-07-08T00:07:16Z

Explanation

References

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've communicated my changes to consumers by updating changelogs for packages I've changed
I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

stanleyyconsensys · 2026-07-08T00:35:47Z

-    if (assetsBalance) {
-      const response: DataResponse = { assetsBalance, updateMode: 'merge' };
-      for (const subscription of this.activeSubscriptions.values()) {
-        subscription.onAssetsUpdate(response)?.catch(console.error);
-      }
+    if (!assetsBalance) {
+      return;
+    }
+
+    const response: DataResponse = { assetsBalance, updateMode: 'merge' };
+    for (const subscription of this.activeSubscriptions.values()) {
+      subscription.onAssetsUpdate(response)?.catch(console.error);


this should not change

stanleyyconsensys · 2026-07-08T00:35:58Z

   * Handle snap balance updates from the keyring.
   * Transforms the payload and publishes to AssetsController.
   *
+   * Push updates carry amounts only. Per-asset snap enrichment (e.g. Stellar


no need to add comment

stanleyyconsensys · 2026-07-08T00:38:28Z

      }
    }

+    if (


we should just add step 3 with Feature flag

stanleyyconsensys · 2026-07-08T10:25:55Z

-            }
-          }
+        results.assetsBalance ??= {};
+        const accountBalances = results.assetsBalance[accountId] ?? {};


on step 3:

if stellar feature flag:

fetch enrichment

update the state (results.assetsBalance)

stanleyyconsensys · 2026-07-08T14:07:46Z

+   * When false, SnapDataSource skips `getAccountAssetInfo` enrichment.
+   * Evaluated at call time. Defaults to () => false.
+   */
+  assetEnrichmentEnabled?: () => boolean;


i think they prefer stellar focus, but up to them

and there are 2 way to get feature flag

use messenger call directly from data source, so u dont need pass in , as we are temp solution, which i think is better (please check packages/network-controller/src/NetworkController.ts)

pass in from client, like what u did

Yep, if poss can we make this stellar specific? This is mostly generic, but let's keep it as a stellar flag

@salimtb confirm we should pass feature flag from client side

change assetEnrichmentEnabled to isStellarEnabled

stanleyyconsensys · 2026-07-08T14:12:41Z

+      })
+    ) {
+      // TODO(STELLAR): Remove this Snap-side accountAssetInfo enrichment path once the Accounts API returns account-asset enrichment directly.
+      await enrichAccountAssetInfo({


um..i feel just do:

call snap

modify data

that will be clear enough
putting into a function, may create complexity, but it also clean

i leave it to Asset team

Suggested change

await enrichAccountAssetInfo({

for (acc in accounts) {

const result = await callSNAP()

mergeResultIntoExistingBalanceData()

}

stanleyyconsensys · 2026-07-08T14:13:21Z

+    const next: Record<string, AssetBalance> = { ...previousBalances };
+    for (const [assetId, balance] of Object.entries(accountBalances)) {
+      next[assetId] = {
+        ...(previousBalances[assetId] ?? { amount: '0' }),


still have amt 0?

Prithpal-Sooriya · 2026-07-09T07:24:09Z


+### Added
+
+- Add optional `snapDataSourceConfig.assetEnrichmentEnabled` getter to `AssetsControllerOptions` so clients can enable or disable snap `getAccountAssetInfo` enrichment at runtime (defaults to disabled)


Let's add the PR number and link.

Prithpal-Sooriya · 2026-07-09T07:25:13Z

 {
  "name": "@metamask/assets-controller",
-  "version": "10.0.1",
+  "version": "10.0.1-dev.8",


Ah nice, didn't know you could do this for testing. Let's clean up

Prithpal-Sooriya · 2026-07-09T07:27:49Z

+   * When false, SnapDataSource skips `getAccountAssetInfo` enrichment.
+   * Evaluated at call time. Defaults to () => false.
+   */
+  assetEnrichmentEnabled?: () => boolean;


Yep, if poss can we make this stellar specific? This is mostly generic, but let's keep it as a stellar flag

Prithpal-Sooriya · 2026-07-09T07:34:07Z

+ * Optional per-asset fields from snap account-asset enrichment.
+ * Stellar classic assets use trustline fields; native XLM may include baseReserve.
+ */
+export type AccountAssetInfo = {


To future proof this, thoughts on making this a discriminated typed union.

{ type: "StellarAccountAssetInfo", ... }

That way we have protection as other future network specific shapes are needed.

Likewise let's also "parse, don't validate" by using @metamask/superstruct to create structs that can parse the right shape (use as type assertion functions).

stanleyyconsensys · 2026-07-09T09:27:39Z

+    // standard (unenriched) balance shape. When the feature flag is enabled
+    // and there are eligible assets, apply accountAssetInfo enrichment once.
+    if (
+      this.#assetEnrichmentEnabled() &&


Suggested change

this.#assetEnrichmentEnabled() &&

this.#isStellarEnabled() &&

stanleyyconsensys · 2026-07-09T09:29:14Z

+    // Post-fetch enrichment stage: assetsBalance above already matches the
+    // standard (unenriched) balance shape. When the feature flag is enabled
+    // and there are eligible assets, apply accountAssetInfo enrichment once.


Suggested change

// Post-fetch enrichment stage: assetsBalance above already matches the

// standard (unenriched) balance shape. When the feature flag is enabled

// and there are eligible assets, apply accountAssetInfo enrichment once.

stanleyyconsensys · 2026-07-09T09:39:54Z

  /** Raw balance amount as string (e.g., "1000000000" for 1000 USDC) */
  amount: string;
+  /** Optional per-asset info from snap account-asset enrichment (e.g. Stellar trustlines). */
+  accountAssetInfo?: AccountAssetInfo;


change accountAssetInfo => metadata

stanleyyconsensys · 2026-07-09T09:40:58Z

+/** Per-asset enrichment keyed by CAIP-19 asset id from snap getAccountAssetInfo. */
+export type GetAccountAssetInfoResponse = Record<
+  Caip19AssetId,
+  AccountAssetInfo


Suggested change

AccountAssetInfo

Record<string, unknown>

client side using super struct to verify the data, when they use it

khanti42 added 3 commits July 8, 2026 02:06

chore: asset enrichment through snap data source

14e36eb

chore: separate enrich logic in helper

e20f4b2

fix: skip snap enrichment when unavailable

dac217f

stanleyyconsensys reviewed Jul 8, 2026

View reviewed changes

stanleyyconsensys changed the title ~~chore: [STELLAR] asset enrichment through snap data source~~ feat(Stellar): asset enrichment through snap data source Jul 8, 2026

khanti42 added 2 commits July 8, 2026 14:46

chore: simplify

31bb1f3

chore: removed getSnapIdForChain

f39d837

stanleyyconsensys reviewed Jul 8, 2026

View reviewed changes

Prithpal-Sooriya reviewed Jul 9, 2026

View reviewed changes

stanleyyconsensys reviewed Jul 9, 2026

View reviewed changes

chore: rollback package.json

ac97644

stanleyyconsensys reviewed Jul 9, 2026

View reviewed changes

khanti42 added 2 commits July 9, 2026 13:14

chore: refactor snap asset metadata enrichment

0260798

chore: dedupe snap request during enrichment

99daf2a

                     }
                   }
+                  if (

-      await enrichAccountAssetInfo({
+     for (acc in accounts) {
+         const result = await callSNAP()
+         mergeResultIntoExistingBalanceData()
+     }


		### Added

		- Add optional `snapDataSourceConfig.assetEnrichmentEnabled` getter to `AssetsControllerOptions` so clients can enable or disable snap `getAccountAssetInfo` enrichment at runtime (defaults to disabled)

	this.#assetEnrichmentEnabled() &&
	this.#isStellarEnabled() &&

	// Post-fetch enrichment stage: assetsBalance above already matches the
	// standard (unenriched) balance shape. When the feature flag is enabled
	// and there are eligible assets, apply accountAssetInfo enrichment once.

Uh oh!

Uh oh!

Conversation

khanti42 commented Jul 8, 2026

Explanation

References

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stanleyyconsensys Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stanleyyconsensys Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stanleyyconsensys Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stanleyyconsensys Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stanleyyconsensys Jul 8, 2026 •

edited

Loading

stanleyyconsensys Jul 8, 2026 •

edited

Loading

stanleyyconsensys Jul 8, 2026 •

edited

Loading

stanleyyconsensys Jul 9, 2026 •

edited

Loading