Repository navigation
fix: make immutable releases fail closed - #52
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
EvoZeus Privacy ScanMode: dry-run Findings
Next action
|
EvoZeus Proof GateMode: dry-run Proof labels
Missing or weak fields
Next action
|
EvoZeus Queue GuardMode: dry-run Author open PRs: 4 Branch family: codex/bug/20260804-infra-v051-release Branch family open PRs: 1 Violations
Next action
|
EvoZeus Labeler ReportPR type/risk labels were updated from changed files. Surfaces
Labels
Changed lines
|
EvoZeus Dirty PR CheckMode: dry-run Surfaces
Reasons
Next action
|
21 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What problem does this PR solve?
The release job exposed the public Release before its asset set was proven complete. With immutable Releases enabled, a failed or slow asset upload could leave a locked incomplete Release.
Why does this matter now?
The v0.5.0 run exposed a temporary interval where the Release appeared without the Core archive. The upload later completed and the final v0.5.0 Release is verified and installable, but the workflow ordering remained unsafe for future tags.
What is the intended outcome?
Release only after immutable configuration, the canonical five assets, and all GitHub SHA-256 digests are verified. Publish failure leaves a reusable draft.
What is intentionally out of scope?
No Core Lesson runtime, CoEvolve, contract bundle, canonical Harness Skill, or target-Skill migration behavior changes.
What should reviewers focus on?
The fail-closed workflow order, exact asset set, digest comparison, and v0.5.0 historical wording.
Linked Context
Related #51
Requested during the v0.5.0 release completion audit.
PR Scope
Primary layer:
Primary artifact kind: Release workflow and v0.5.1 product metadata
One thing this PR does: makes immutable Release publication fail closed.
What this PR does not do: change the v0.5 product composition or target-repository Harness migration rules.
EvoZeus Evidence Proof
npm test;npm run test:python;claude plugin validate .;python3 scripts/check_pr_ready.py;npm audit --audit-level=high; YAML and diff checks.Verdict / Review Gate
Review gates checked:
Tests and Validation
Commands run:
npm test,npm run test:python,claude plugin validate .,npm audit --audit-level=high,python3 scripts/check_pr_ready.py,git diff --check, YAML parse.All executed checks passed after updating the legacy preflight integration assertion for the multiline canonical asset array.
Risk Checklist
Did user-visible behavior change? (
Yes)Did SKILL.md, public instructions, or agent behavior change? (
No)Did privacy, security, network, auth, or tool permission behavior change? (
Yes)Did schema, storage, branch, PR, or governance behavior change? (
Yes)Highest-risk area: Release publication and immutable configuration drift.
How is that risk mitigated? The job stops while the Release is still a draft unless repository immutability, exact asset count, and every digest pass.
AI-Assisted Work
Was this PR written or materially changed by an AI coding agent? (
Yes)Codex implemented and tested the change; an independent subagent audited remote Release evidence and the workflow boundary.
Confirm the author understands the changed behavior:
Current Review State
Next action: run required CI, merge, update the single UAT, then create and verify v0.5.1.
Still waiting on author, maintainer, CI, or external proof: required GitHub checks and real-tag Release proof.
Reviewer or bot comments addressed: independent audit blockers were fixed before opening the PR.
Privacy Checklist
Operational Checklist
python3 scripts/check_pr_ready.pypassesgit diff --checkpasses