Fix e2e tests

[SimaoBolota-MetaCell]

No description provided.

[jrmartin]

@SimaoBolota-MetaCell Thanks Simao

[jrmartin]

@SimaoBolota-MetaCell Can you revert the changes to package.json and yarn.lock please, those should be left untouched. The jest/puppeteer dependencies need to be the latest to avoid this security risk, where older jest/puppeter version are using an unsecured dependency.

[SimaoBolota-MetaCell]

I need some help @jrmartin
because the only way I got the tests to work was to do the changes I had done in the PR
otherwise I keep getting errors where the easiest solution is change the versions
By not changing the versions I keep constantly getting configuration and version mismatches errors, could you have a look when you get a chance?

[SimaoBolota-MetaCell]

@jrmartin Can you check if these versions work?
The only way to fix the current issue was to update some versions, apparently they were incompatible like you had them so I had to update some to match the latest of other jest and puppeteer versions
With this the tests now run and pass as expected

[SimaoBolota-MetaCell]

@jrmartin in the QA sync Filippo mentioned the fact that the tests could not be testing the latest as they are running for a set URL directly in the tests. So I changed the github actions flow for the tests to run right after the deployment actions step is successful

[jrmartin]

@jrmartin in the QA sync Filippo mentioned the fact that the tests could not be testing the latest as they are running for a set URL directly in the tests. So I changed the github actions flow for the tests to run right after the deployment actions step is successful

Yeah that's a good catch, to change this behavior though we need a slightly different approach. @SimaoBolota-MetaCell
The workflow needs to trigger when a PR is opened to main or development, we can not removed those triggers from the workflow. Instead we need to add a new step to run the local dev app and point the tests to this endpoint to test code on current branch.

I started this branch (using your branch as base) to test this setup, using the local development instead of the github pages deployment.
The workflow here will continue being triggered on PR's to main and development, but will also have an extra step to run the local environment and make that endpoint available for tests to use. Once this build fixes I'll let you know so your branch can use this workflow and i'll close my branch.

Also looking at deps issue

[jrmartin]

@SimaoBolota-MetaCell This PR should do it for the workflows setup to use local development and points tests to it. I opened this new PR to be merged to your branch, I added you as reviewer to review changes before making it to your branch. Also minor update to .lock. Tested on previous branch I closed and worked https://github.com/MetaCell/sds-viewer/actions/runs/16170586303

[jrmartin]

Great, looks good ! Thanks for extra push @SimaoBolota-MetaCell