feat: improve overlay ID management#191
Merged
Merged
Conversation
seankmartin
commented
Jun 9, 2026
seankmartin
commented
- fix: retain overlay segments in merge/split and undo also supress browse if last node deleted, and allow to unsupress browse. Catmaid generates new IDs so generally not a problem. But good to cover just in case it ever changes to reuse IDs.
- fix: remove hard ties between memory cache and overlay segments Replaces soft/hard supression duplicates with one source of overlay IDs. Also always add to this set of overlay IDs and don't clear it on refetch
also supress browse if last node deleted, and allow to unsupress browse. Catmaid generates new IDs so generally not a problem. But good to cover just in case it ever changes to reuse IDs.
Replaces soft/hard supression duplicates with one source of overlay IDs. Also always add to this set of overlay IDs and don't clear it on refetch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.