Skip to content

fix: correct tree details height and css layout and old classes #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seankmartin merged 1 commit into from
Jun 9, 2026
Merged

fix: correct tree details height and css layout and old classes #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 19 additions & 19 deletions src/layer/segmentation/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2195,7 +2195,7 @@ export class SegmentationUserLayer extends Base {
: undefined;
const nodeInfo = completeNodeInfo ?? previewNodeInfo;
const container = document.createElement("div");
container.classList.add("neuroglancer-spatial-skeleton-selection");
container.classList.add("neuroglancer-selection-details-skeleton");
parent.appendChild(container);

const appendValue = (label: string, value: string | HTMLElement) => {
Expand Down Expand Up @@ -2223,7 +2223,7 @@ export class SegmentationUserLayer extends Base {
);
const segmentIdChip = document.createElement("span");
segmentIdChip.className =
"neuroglancer-spatial-skeleton-node-segment-chip";
"neuroglancer-selection-details-skeleton-segment-chip";
segmentIdChip.textContent = `${segmentId}`;
segmentIdChip.style.backgroundColor = segmentChipColors.background;
segmentIdChip.style.color = segmentChipColors.foreground;
Expand Down Expand Up @@ -2282,7 +2282,7 @@ export class SegmentationUserLayer extends Base {
nodeType,
});
const summaryRow = document.createElement("div");
summaryRow.classList.add("neuroglancer-spatial-skeleton-selection-summary");
summaryRow.classList.add("neuroglancer-selection-details-skeleton-summary");
container.appendChild(summaryRow);

const editSource = getEditableSpatiallyIndexedSkeletonSource(skeletonLayer);
Expand All @@ -2301,7 +2301,7 @@ export class SegmentationUserLayer extends Base {
);
const rerootButton = document.createElement("button");
rerootButton.type = "button";
rerootButton.className = "neuroglancer-spatial-skeleton-selection-action";
rerootButton.className = "neuroglancer-selection-details-skeleton-action";
rerootButton.disabled = rerootDisabledReason !== undefined;
rerootButton.title = rerootDisabledReason ?? "Set as root";
rerootButton.appendChild(
Expand Down Expand Up @@ -2347,7 +2347,7 @@ export class SegmentationUserLayer extends Base {
);
const deleteButton = document.createElement("button");
deleteButton.type = "button";
deleteButton.className = "neuroglancer-spatial-skeleton-selection-action";
deleteButton.className = "neuroglancer-selection-details-skeleton-action";
deleteButton.disabled = deleteDisabledReason !== undefined;
deleteButton.title = deleteDisabledReason ?? "Delete node";
deleteButton.appendChild(
Expand Down Expand Up @@ -2378,7 +2378,7 @@ export class SegmentationUserLayer extends Base {
summaryRow.appendChild(deleteButton);

const icon = document.createElement("span");
icon.className = "neuroglancer-spatial-skeleton-selection-summary-icon";
icon.className = "neuroglancer-selection-details-skeleton-summary-icon";
const nodeTypeIconTitle =
iconFilterType !== undefined
? getSpatialSkeletonNodeFilterLabel(iconFilterType)
Expand Down Expand Up @@ -2429,7 +2429,7 @@ export class SegmentationUserLayer extends Base {
);
const summaryCoordinates = document.createElement("span");
summaryCoordinates.className =
"neuroglancer-spatial-skeleton-selection-summary-coordinates";
"neuroglancer-selection-details-skeleton-summary-coordinates";
summaryCoordinates.textContent = position.displayText;
summaryCoordinates.title = position.fullText;
summaryRow.appendChild(summaryCoordinates);
Expand All @@ -2449,24 +2449,24 @@ export class SegmentationUserLayer extends Base {
let committedTrueEnd = nodeHasTrueEnd;
let leafTypeSavePending = false;
const leafTypeEditor = document.createElement("div");
leafTypeEditor.className = "neuroglancer-spatial-skeleton-leaf-type";
const leafTypeRadioName = `neuroglancer-spatial-skeleton-leaf-type-${segmentId}-${fullNodeInfo.nodeId}`;
leafTypeEditor.className = "neuroglancer-selection-details-skeleton-leaf-type";
const leafTypeRadioName = `neuroglancer-selection-details-skeleton-leaf-type-${segmentId}-${fullNodeInfo.nodeId}`;
const leafTypeOptionElements: HTMLLabelElement[] = [];
const makeLeafTypeOption = (options: {
label: string;
svg: string;
trueEnd: boolean;
}) => {
const option = document.createElement("label");
option.className = "neuroglancer-spatial-skeleton-leaf-type-option";
option.className = "neuroglancer-selection-details-skeleton-leaf-type-option";
const input = document.createElement("input");
input.type = "radio";
input.name = leafTypeRadioName;
input.value = options.trueEnd ? "trueEnd" : "virtualEnd";
input.className =
"neuroglancer-spatial-skeleton-leaf-type-option-input";
"neuroglancer-selection-details-skeleton-leaf-type-option-input";
const icon = document.createElement("span");
icon.className = "neuroglancer-spatial-skeleton-leaf-type-option-icon";
icon.className = "neuroglancer-selection-details-skeleton-leaf-type-option-icon";
icon.appendChild(
makeIcon({
svg: options.svg,
Expand All @@ -2475,7 +2475,7 @@ export class SegmentationUserLayer extends Base {
}),
);
const text = document.createElement("span");
text.className = "neuroglancer-spatial-skeleton-leaf-type-option-text";
text.className = "neuroglancer-selection-details-skeleton-leaf-type-option-text";
text.textContent = options.label;
option.appendChild(input);
option.appendChild(icon);
Expand Down Expand Up @@ -2509,7 +2509,7 @@ export class SegmentationUserLayer extends Base {
}
for (const option of leafTypeOptionElements) {
option.classList.toggle(
"neuroglancer-spatial-skeleton-leaf-type-option-disabled",
"neuroglancer-selection-details-skeleton-leaf-type-option-disabled",
!editable,
);
if (disabledReason !== undefined) {
Expand Down Expand Up @@ -2585,7 +2585,7 @@ export class SegmentationUserLayer extends Base {
disabledReason: string | undefined,
) => {
input.classList.toggle(
"neuroglancer-spatial-skeleton-properties-input-invalid",
"neuroglancer-selection-details-skeleton-properties-input-invalid",
!valid,
);
if (disabledReason !== undefined) {
Expand Down Expand Up @@ -2639,7 +2639,7 @@ export class SegmentationUserLayer extends Base {
} else {
let committedRadius = fullNodeInfo.radius ?? 0;
const radiusInput = document.createElement("input");
radiusInput.className = "neuroglancer-spatial-skeleton-properties-input";
radiusInput.className = "neuroglancer-selection-details-skeleton-properties-input";
radiusInput.type = "number";
radiusInput.step = "any";
radiusInput.value = formatSpatialSkeletonEditableNumber(
Expand Down Expand Up @@ -2744,7 +2744,7 @@ export class SegmentationUserLayer extends Base {
);
const confidenceControl = document.createElement("select");
confidenceControl.className =
"neuroglancer-spatial-skeleton-properties-input";
"neuroglancer-selection-details-skeleton-properties-input";
for (const value of confidenceSelectValues) {
const option = document.createElement("option");
option.value = value.toString();
Expand Down Expand Up @@ -2845,7 +2845,7 @@ export class SegmentationUserLayer extends Base {
if (descriptionEditingDisabledReason === undefined) {
const descriptionElement = document.createElement("textarea");
descriptionElement.classList.add(
"neuroglancer-spatial-skeleton-selection-description",
"neuroglancer-selection-details-skeleton-description",
);
descriptionElement.rows = 3;
descriptionElement.placeholder = "Description";
Expand Down Expand Up @@ -2895,7 +2895,7 @@ export class SegmentationUserLayer extends Base {
} else if (descriptionText.length > 0) {
const descriptionElement = document.createElement("div");
descriptionElement.classList.add(
"neuroglancer-spatial-skeleton-selection-description",
"neuroglancer-selection-details-skeleton-description",
);
descriptionElement.textContent = descriptionText;
descriptionElement.title = descriptionEditingDisabledReason;
Expand Down
Loading