feat: allow to highlight nodes from the spatial index#186
Merged
Conversation
seankmartin
commented
Jun 8, 2026
- fix: correct global bind key
- fix: allow seg ID to use display state
- feat: allow highlighting nodes from spatial index main changes are: 1. Cleaner repr of selected texture. Now stores a nodeID per vertex, instead of updating a 1D texture which effectively stores a bool of the highlihgted node. Then passes a uniform about the current node. 2. Removes now uneeded 1D texture update. 3. Cleans up some shader ternary ops to use mix. 4. Uses less GPU mem in overlay pass. As a note, this also would allow to do per node discarding which is something we discussed previously if ever really needed.
main changes are: 1. Cleaner repr of selected texture. Now stores a nodeID per vertex, instead of updating a 1D texture which effectively stores a bool of the highlihgted node. Then passes a uniform about the current node. 2. Removes now uneeded 1D texture update. 3. Cleans up some shader ternary ops to use mix. 4. Uses less GPU mem in overlay pass. As a note, this also would allow to do per node discarding which is something we discussed previously if ever really needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.