Skip to content

feat: Update catmaid implementation to work with latest image#181

Merged
seankmartin merged 8 commits into
feature/edit-modefrom
feature/NA-809
Jun 5, 2026
Merged

feat: Update catmaid implementation to work with latest image#181
seankmartin merged 8 commits into
feature/edit-modefrom
feature/NA-809

Conversation

@afonsobspinto

@afonsobspinto afonsobspinto commented May 26, 2026

Copy link
Copy Markdown
Member

Closes https://metacell.atlassian.net/browse/NA-809
Closes https://metacell.atlassian.net/browse/NA-818

This PR drops support of catmaid servers that use a version older than commit ed261715a0c4b2b1698dfd9a0e2d6f4233533f19

@afonsobspinto afonsobspinto marked this pull request as ready for review May 26, 2026 23:07
@afonsobspinto afonsobspinto requested a review from seankmartin May 26, 2026 23:07

@seankmartin seankmartin left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks a lot cleaner, thanks. Left one comment about handling versions

Comment thread src/datasource/catmaid/api.ts Outdated
@afonsobspinto afonsobspinto requested review from seankmartin and removed request for seankmartin May 27, 2026 18:07
@afonsobspinto afonsobspinto marked this pull request as draft May 27, 2026 18:09
@afonsobspinto afonsobspinto marked this pull request as ready for review May 27, 2026 20:26
@afonsobspinto afonsobspinto requested a review from seankmartin May 27, 2026 20:34
I guess a force push might have happened
Also simplifies the test a bit
@seankmartin seankmartin merged commit 2f071e8 into feature/edit-mode Jun 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants