Skip to content

CELE-149 Add hook system to plug conversion scripts for synapses#112

Merged
ddelpiano merged 3 commits into
developfrom
feature/CELE-149
Aug 29, 2025
Merged

CELE-149 Add hook system to plug conversion scripts for synapses#112
ddelpiano merged 3 commits into
developfrom
feature/CELE-149

Conversation

@aranega

@aranega aranega commented Aug 28, 2025

Copy link
Copy Markdown
Member

coordinate computation

@aranega aranega requested review from Copilot and ddelpiano August 28, 2025 12:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a hook system for coordinate conversion of synapse 3D models during ingestion. The change allows users to provide custom conversion scripts to transform synapse coordinates, replacing hardcoded coordinate transformation logic.

  • Adds dynamic loading of conversion scripts from synapse directories
  • Replaces hardcoded .obj file coordinate transformation with pluggable conversion system
  • Updates documentation to explain the new conversion script feature

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
ingestion/ingestion/ingest.py Implements the hook system with dynamic script loading and removes hardcoded coordinate transformation
ingestion/README.md Documents the new conversion script feature with examples and file structure

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread ingestion/ingestion/ingest.py Outdated
Comment thread ingestion/ingestion/ingest.py
Comment thread ingestion/README.md Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ddelpiano ddelpiano merged commit 2121524 into develop Aug 29, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants