Repository navigation
Implement hybrid SW scattering allowing direct flux only calculations for specific k-terms - #47
Open
James Manners (mo-jmanners) wants to merge 7 commits into
Open
James Manners (mo-jmanners) wants to merge 7 commits into
James Manners (mo-jmanners) wants to merge 7 commits into
Conversation
… gas k-terms to use a simple direct flux calculation with no scattering or clouds. Improve selection of major absorber in tidy_90 (allow up to 3 gas layers). Update RFMIP KGO due to use of l_grey_single. Remove overkill calculation of spherical ice from slow_tests.
…ect major gas in sp_uv example. Small fix to tidy_90 to cope with very optically thick gas in EUV. Update technical guide for SW hybrid scattering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Implement hybrid SW scattering allowing direct flux only calculations for specific k-terms
Sci/Tech Reviewer: Dr Stephan Havemann (@Petzi1)
Code Reviewer:
Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
Testing
Stand-alone Socrates testing
UM trac.log
Test Suite Results - um - um_socrates46_hybrid_scatter_sw/run1
Suite Information
Approvals
Code Owners
Config Owners
No UM Config Owners Required
Task Information
✅ succeeded tasks - 895
LFRic Apps trac.log
Test Suite Results - lfric_apps - lfric_apps_socrates46_hybrid_scatter_sw/run1
Suite Information
Task Information
✅ succeeded tasks - 1256
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
Sci/Tech Review
Please alert the code reviewer via a tag when you have approved the SR
Code Review